Skip to content

Fix missing response size#2642

Merged
istio-testing merged 1 commit intoistio:release-1.4from
kyessenov:response_size
Jan 31, 2020
Merged

Fix missing response size#2642
istio-testing merged 1 commit intoistio:release-1.4from
kyessenov:response_size

Conversation

@kyessenov
Copy link
Contributor

@kyessenov kyessenov commented Jan 30, 2020

Manually verified:

istio_response_bytes_bucket{reporter="destination",source_workload="productpage-v1",source_workload_namespace="default",source_principal="unknown",source_app="productpage",source_version="v1",destination_workload="ratings-v1",destination_workload_namespace="default",destination_principal="unknown",destination_app="ratings",destination_version="v1",destination_service="server.default.svc.cluster.local",destination_service_name="server",destination_service_namespace="default",request_protocol="http",response_code="200",response_flags="-",connection_security_policy="NONE",permissive_response_code="none",permissive_response_policyid="none",le="+Inf"} 10

@kyessenov
pick up fixes from istio/envoy
e99b0db 
Signed-off-by: Kuat Yessenov <kuat@google.com>
@kyessenov kyessenov requested a review from a team January 30, 2020 19:40
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 30, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 30, 2020
howardjohn
howardjohn requested changes Jan 30, 2020
View reviewed changes
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any more info on this? Looks like the envoy changes were force pushed to release-1.4? Are these already in master?

@kyessenov
Copy link
Contributor Author

kyessenov commented Jan 30, 2020

@howardjohn those are cherry-picks from envoy master to istio envoy 1.4.
CI is blocked on go: google.golang.org/genproto@v0.0.0-20190819201941-24fa4b261c55: invalid $GOPROXY setting: cannot have comma. Where is GOPROXY set and why there is a comma there?

@howardjohn
Copy link
Member

howardjohn commented Jan 30, 2020

Its in test-infra repo, caused by a recent change. We must be using and older go version (1.12) than the other repos here. Should be an easy fix.

@howardjohn howardjohn mentioned this pull request Jan 30, 2020
Closed
@kyessenov kyessenov mentioned this pull request Jan 30, 2020
Closed
@howardjohn
Copy link
Member

howardjohn commented Jan 30, 2020

/retest

2 similar comments
@howardjohn
Copy link
Member

howardjohn commented Jan 30, 2020

/retest

@howardjohn
Copy link
Member

howardjohn commented Jan 30, 2020

/retest

mandarjog
mandarjog approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@mandarjog mandarjog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@douglas-reid
Copy link
Contributor

douglas-reid commented Jan 31, 2020

@kyessenov this includes the hardening PR, correct?

@mandarjog
Copy link
Contributor

mandarjog commented Jan 31, 2020

Yes it includes: istio/envoy@b5c068e

@douglas-reid
Copy link
Contributor

douglas-reid commented Jan 31, 2020

@mandarjog will this be cherry-picked against master and release-1.5 too then?

@istio-testing istio-testing merged commit 24d984c into istio:release-1.4 Jan 31, 2020
howardjohn pushed a commit that referenced this pull request Feb 11, 2020
@mandarjog @kyessenov
pick up fixes from istio/envoy (#2642) (#15)
4cd27af 
Signed-off-by: Kuat Yessenov <kuat@google.com>

Co-authored-by: Kuat <kyessenov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howardjohn howardjohn howardjohn approved these changes

+1 more reviewer

@mandarjog mandarjog mandarjog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kyessenov @howardjohn @douglas-reid @mandarjog @googlebot @istio-testing