Skip to content

Simplify trace sampled condition#2627

Merged
istio-testing merged 1 commit intoistio:masterfrom
bianpengyuan:extend-request-info
Jan 16, 2020
Merged

Simplify trace sampled condition#2627
istio-testing merged 1 commit intoistio:masterfrom
bianpengyuan:extend-request-info

Conversation

@bianpengyuan
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@bianpengyuan bianpengyuan requested review from a team and yxue January 16, 2020 18:26
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 16, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 16, 2020
Copy link
Contributor

@mandarjog mandarjog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Member

@yxue yxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@istio-testing istio-testing merged commit e30fa43 into istio:master Jan 16, 2020
bianpengyuan added a commit to bianpengyuan/proxy that referenced this pull request Jan 17, 2020
istio-testing pushed a commit that referenced this pull request Jan 28, 2020
* Add extra labels to sd logging (#2625)

* add extra fields into request info

* add logic to export extended request info

* add initial value

* update wasm file

* address comment

* fix

* simplify trace sampled condition (#2627)

* format
howardjohn pushed a commit that referenced this pull request Feb 11, 2020
* Add extra labels to sd logging (#2625)

* add extra fields into request info

* add logic to export extended request info

* add initial value

* update wasm file

* address comment

* fix

* simplify trace sampled condition (#2627)

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants