Skip to content

Update Envoy SHA to head of istio/envoy:release-1.3#2582

Closed
rlenglet wants to merge 1 commit intorelease-1.3from
update-release-1.3-envoy-sha
Closed

Update Envoy SHA to head of istio/envoy:release-1.3#2582
rlenglet wants to merge 1 commit intorelease-1.3from
update-release-1.3-envoy-sha

Conversation

@rlenglet
Copy link
Contributor

No description provided.

@rlenglet rlenglet requested a review from a team November 26, 2019 01:43
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 26, 2019
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 26, 2019
@rlenglet rlenglet mentioned this pull request Nov 26, 2019
24 tasks
@rlenglet
Copy link
Contributor Author

The macos build fails with:

ERROR: /Users/distiller/.cache/bazel/external/envoy/source/extensions/filters/network/kafka/BUILD:187:1: Executing genrule @envoy//source/extensions/filters/network/kafka:serialization_composite_generated_source failed (Exit 1) bash failed: error executing command 
  (cd /Users/distiller/.cache/bazel/sandbox/darwin-sandbox/51/execroot/__main__ && \
  exec env - \
    BAZEL_LINKLIBS=-l%:libstdc++.a \
    BAZEL_LINKOPTS=-lm:-static-libgcc \
    CC=clang \
    CXX=clang++ \
    PATH=/usr/lib/llvm-8/bin:/usr/local/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin \
  /bin/bash -c 'source external/bazel_tools/tools/genrule/genrule-setup.sh; 
      ./bazel-out/host/bin/external/envoy/source/extensions/filters/network/kafka/serialization_composite_code_generator_bin       bazel-out/darwin-opt/bin/external/envoy/source/extensions/filters/network/kafka/external/serialization_composite.h
    ')
Execution platform: @bazel_tools//platforms:host_platform

Use --sandbox_debug to see verbose messages from the sandbox
ERROR:root:code for hash md5 was not found.
Traceback (most recent call last):
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 147, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 97, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type md5
ERROR:root:code for hash sha1 was not found.
Traceback (most recent call last):
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 147, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 97, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type sha1
ERROR:root:code for hash sha224 was not found.
Traceback (most recent call last):
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 147, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 97, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type sha224
ERROR:root:code for hash sha256 was not found.
Traceback (most recent call last):
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 147, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 97, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type sha256
ERROR:root:code for hash sha384 was not found.
Traceback (most recent call last):
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 147, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 97, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type sha384
ERROR:root:code for hash sha512 was not found.
Traceback (most recent call last):
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 147, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 97, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type sha512
ERROR:root:code for hash md5 was not found.
Traceback (most recent call last):
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 147, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 97, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type md5
ERROR:root:code for hash sha1 was not found.
Traceback (most recent call last):
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 147, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 97, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type sha1
ERROR:root:code for hash sha224 was not found.
Traceback (most recent call last):
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 147, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 97, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type sha224
ERROR:root:code for hash sha256 was not found.
Traceback (most recent call last):
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 147, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 97, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type sha256
ERROR:root:code for hash sha384 was not found.
Traceback (most recent call last):
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 147, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 97, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type sha384
ERROR:root:code for hash sha512 was not found.
Traceback (most recent call last):
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 147, in <module>
    globals()[__func_name] = __get_hash(__func_name)
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/hashlib.py", line 97, in __get_builtin_constructor
    raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type sha512
Traceback (most recent call last):
  File "/Users/distiller/.cache/bazel/sandbox/darwin-sandbox/51/execroot/__main__/./bazel-out/host/bin/external/envoy/source/extensions/filters/network/kafka/serialization_composite_code_generator_bin.runfiles/envoy/source/extensions/filters/network/kafka/serialization/launcher.py", line 33, in <module>
    main()
  File "/Users/distiller/.cache/bazel/sandbox/darwin-sandbox/51/execroot/__main__/./bazel-out/host/bin/external/envoy/source/extensions/filters/network/kafka/serialization_composite_code_generator_bin.runfiles/envoy/source/extensions/filters/network/kafka/serialization/launcher.py", line 29, in main
    generator.generate_main_code(serialization_composite_h_file)
  File "/Users/distiller/.cache/bazel/sandbox/darwin-sandbox/51/execroot/__main__/bazel-out/host/bin/external/envoy/source/extensions/filters/network/kafka/serialization_composite_code_generator_bin.runfiles/envoy/source/extensions/filters/network/kafka/serialization/generator.py", line 12, in generate_main_code
    generate_code('serialization_composite_h.j2', serialization_composite_h_file)
  File "/Users/distiller/.cache/bazel/sandbox/darwin-sandbox/51/execroot/__main__/bazel-out/host/bin/external/envoy/source/extensions/filters/network/kafka/serialization_composite_code_generator_bin.runfiles/envoy/source/extensions/filters/network/kafka/serialization/generator.py", line 30, in generate_code
    template = RenderingHelper.get_template(template_name)
  File "/Users/distiller/.cache/bazel/sandbox/darwin-sandbox/51/execroot/__main__/bazel-out/host/bin/external/envoy/source/extensions/filters/network/kafka/serialization_composite_code_generator_bin.runfiles/envoy/source/extensions/filters/network/kafka/serialization/generator.py", line 50, in get_template
    import jinja2
  File "/Users/distiller/.cache/bazel/sandbox/darwin-sandbox/51/execroot/__main__/bazel-out/host/bin/external/envoy/source/extensions/filters/network/kafka/serialization_composite_code_generator_bin.runfiles/com_github_pallets_jinja/jinja2/__init__.py", line 36, in <module>
    from jinja2.loaders import BaseLoader, FileSystemLoader, PackageLoader, \
  File "/Users/distiller/.cache/bazel/sandbox/darwin-sandbox/51/execroot/__main__/bazel-out/host/bin/external/envoy/source/extensions/filters/network/kafka/serialization_composite_code_generator_bin.runfiles/com_github_pallets_jinja/jinja2/loaders.py", line 16, in <module>
    from hashlib import sha1
ImportError: cannot import name sha1
----------------
Note: The failure of target @envoy//source/extensions/filters/network/kafka:serialization_composite_code_generator_bin (with exit code 1) may have been caused by the fact that it is running under Python 2 instead of Python 3. Examine the error to determine if that appears to be the problem. Since this target is built in the host configuration, the only way to change its version is to set --host_force_python=PY3, which affects the entire build.

If this error started occurring in Bazel 0.27 and later, it may be because the Python toolchain now enforces that targets analyzed as PY2 and PY3 run under a Python 2 and Python 3 interpreter, respectively. See https://github.com/bazelbuild/bazel/issues/7899 for more information.
----------------
Target //src/envoy:envoy failed to build

This may be due to the only change in istio/envoy:release-1.3 that is picked up by this PR: istio/envoy#123

CC @fpesce @yxue who merged that PR.

@rlenglet
Copy link
Contributor Author

@yxue any clue why this build fails?

@rlenglet
Copy link
Contributor Author

@howardjohn would you be able to force-merge this PR? Only the macos test failed due to a wrong Python version. Getting this merged will unblock me to build 1.3.6. Thanks!

@rlenglet
Copy link
Contributor Author

Will retry this later.

@rlenglet rlenglet closed this Nov 26, 2019
@rlenglet rlenglet deleted the update-release-1.3-envoy-sha branch November 26, 2019 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants