Add test for Http Metadata exchange #2567
Merged
istio-testing merged 2 commits intoistio:masterfrom Dec 19, 2019
Merged
Conversation
googlebot
added
the
cla: yes
istio-testing
added
the
size/XL
gargnupur
commented
Nov 14, 2019
| @@ -257,7 +257,7 @@ void MetadataExchangeFilter::tryReadProxyData(Buffer::Instance& data) { | |||
| setFilterState(config_->filter_direction_ == FilterDirection::Downstream | |||
Contributor
Author
There was a problem hiding this comment.
Changes in this file are covered by https://github.com/istio/proxy/pull/2565/files PR
istio-testing
added
size/XXL
gargnupur
force-pushed
the
nup_http_meta2
branch
from
77006fb to
6d64c2d
Compare
istio-testing
added
size/XL
gargnupur
force-pushed
the
nup_http_meta2
branch
from
6d64c2d to
efceb80
Compare
istio-testing
added
needs-rebase
gargnupur
force-pushed
the
nup_http_meta2
branch
from
108685a to
4c270c7
Compare
Cleanup ports Format http server Add ability to add client and server yaml files that test finally uses Add more validation for source and destination app in http test Upgrade to latest envoy-wasm Fix failures in tests Fix lint errors Fix lint errors Fix tests Fix tests
gargnupur
force-pushed
the
nup_http_meta2
branch
from
b3d017c to
534d141
Compare
kyessenov
reviewed
Dec 13, 2019
| "pod-template-hash": "84975bc778" | ||
| }, | ||
| "ISTIO_PROXY_SHA": "istio-proxy:47e4559b8e4f0d516c0d17b233d127a3deb3d7ce", | ||
| "NAME": "ratings-v1-84975bc778-pxz2w",` |
Contributor
There was a problem hiding this comment.
nit: please don't embed config in sources. They are difficult to upgrade when the config needs to be changed.
Contributor
Author
There was a problem hiding this comment.
Agreed.. there is a lot of common config in tests.. will update them all together into templates...
Contributor
There was a problem hiding this comment.
I started dumping them into https://github.com/istio/proxy/tree/master/testdata. You just need to assemble them as necessary.
Contributor
Author
There was a problem hiding this comment.
will do that, in a cleanup cl following this PR
kyessenov
approved these changes
Dec 13, 2019
Contributor
kyessenov
left a comment
kyessenov
left a comment
There was a problem hiding this comment.
Thanks! We can clean up / de-duplicate the test artifacts later.
Contributor
Author
|
/test test-tsan_proxy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add test for Http Metadata exchange using network metadata exchange filter and prometheus stats filter.
This PR also, cleans up envoy config for http requests and makes it more easy to use and understand.
It currently depends on envoyproxy/envoy-wasm#310 to work properly