Use struct value in setfilterstate in metadata exchange filter#2565
Merged
istio-testing merged 1 commit intoistio:masterfrom Nov 14, 2019
Merged
Use struct value in setfilterstate in metadata exchange filter#2565istio-testing merged 1 commit intoistio:masterfrom
istio-testing merged 1 commit intoistio:masterfrom
Conversation
Use struct value when setting filter state for metadata exchange filter
googlebot
added
the
cla: yes
istio-testing
added
the
size/XS
kyessenov
approved these changes
Nov 14, 2019
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Use struct value in setfilterstate in metadata exchange filter
When setting filterstate in metadata exchange filter, currently it is setting serialized bytes of Envoy::ProbufWkt::Value itself, rather than the underlying object of Value, because of which stats plugin can's deserialize it.