Update Envoy-WASM SHA to latest with HTTP inspector fixes.#2549
Update Envoy-WASM SHA to latest with HTTP inspector fixes.#2549istio-testing merged 1 commit intoistio:release-1.4from
Conversation
Pulling in istio/envoy#120. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
googlebot
added
the
cla: yes
istio-testing
added
the
size/XS
|
/test proxy-presubmit |
5 similar comments
|
/test proxy-presubmit |
|
/test proxy-presubmit |
|
/test proxy-presubmit |
|
/test proxy-presubmit |
|
/test proxy-presubmit |
|
/retest |
|
Why is this getting an exception when the ALS one is not? Shouldn't we wait until we decide on what to do about the proxy version (basing off envoy stable or master) ? |
|
/hold |
rshriram
left a comment
rshriram
left a comment
There was a problem hiding this comment.
I would like to see a clear explanation for this dual policy of blocking specific upstream changes until envoy release while still cherry picking ones into our fork and syncing to istio/proxy.
|
@rshriram this is a security fix. |
|
/test proxy-presubmit |
howardjohn
dismissed
rshriram’s stale review
this has been answered and blocking 1.4.0
|
/retest |
|
/test proxy-presubmit |
|
@rshriram could you remove the |
|
I think @rshriram 's discussion is reasonable, but we should not block the release on this |
|
My point is that we have a very buggy ALS system in 1.4 release today. And fixes for those are not allowed because of deviation from the baseline release. So why is this ? We could turn off sniffing (we already do) in inbound. So, this might as well wait for an entire release ? |
|
@rshriram the whole point of stable releases of Envoy and using them in Istio Proxy is to support bugfixes such as the ALS one. I don't recall anybody not allowing it to be cherry-picked... |
|
/test proxy-presubmit-asan |
|
@PiotrSikora @rshriram yeah sure let's cherry-pick, PTAL istio/envoy#121 |
7 participants
Pulling in istio/envoy#120.
Signed-off-by: Piotr Sikora piotrsikora@google.com