[release-1.4] Fix building extensions as WebAssembly modules (again).#2538
Merged
istio-testing merged 1 commit intoistio:release-1.4from Nov 8, 2019
Merged
[release-1.4] Fix building extensions as WebAssembly modules (again).#2538istio-testing merged 1 commit intoistio:release-1.4from
istio-testing merged 1 commit intoistio:release-1.4from
Conversation
Those WebAssembly modules are not built as part of the CI yet, because we cannot run Docker-in-Docker. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
googlebot
added
the
cla: yes
istio-testing
added
the
size/S
Contributor
Author
|
For some reason, the automatic cherry-pick of #2528 failed. |
Contributor
Author
|
/test proxy-presubmit-asan |
jwendell
approved these changes
Nov 8, 2019
Member
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those WebAssembly modules are not built as part of the CI yet,
because we cannot run Docker-in-Docker.
Signed-off-by: Piotr Sikora piotrsikora@google.com