Skip to content

[1.4] update envoy sha#2537

Merged
istio-testing merged 1 commit intoistio:release-1.4from
lambdai:listenerfilterto
Nov 7, 2019
Merged

[1.4] update envoy sha#2537
istio-testing merged 1 commit intoistio:release-1.4from
lambdai:listenerfilterto

Conversation

@lambdai
Copy link
Contributor

@lambdai lambdai commented Nov 7, 2019

Signed-off-by: Yuchen Dai silentdai@gmail.com

pickup istio/envoy#119 to fix excessive cpu usage

Signed-off-by: Yuchen Dai <silentdai@gmail.com>
@lambdai lambdai requested a review from a team November 7, 2019 21:42
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 7, 2019
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2019
@lambdai
Copy link
Contributor Author

lambdai commented Nov 7, 2019

/retest prow/proxy-presubmit.sh

@lambdai
Copy link
Contributor Author

lambdai commented Nov 7, 2019

@bianpengyuan Could take a look at the mixer fault test. This magically 404 make think it's http 404 instead of integer 404

test/integration/mixer_fault_test.cc:823: Failure
Expected equality of these values:
  client->class2xxResponses()
    Which is: 496
  requests_to_send
    Which is: 900
Stack trace:
  0x24c5542: Mixer::Integration::MixerFaultTest_FailOpenAndSendPolicyResponseSlowly_Test::TestBody()
  0x62a7664: testing::internal::HandleSehExceptionsInMethodIfSupported<>()
  0x6297c5b: testing::internal::HandleExceptionsInMethodIfSupported<>()
  0x6285853: testing::Test::Run()
  0x6286217: testing::TestInfo::Run()
... Google Test internal frames ...

test/integration/mixer_fault_test.cc:826: Failure
Expected equality of these values:
  client->responseTimeouts()
    Which is: 404
  0

@bianpengyuan
Copy link
Contributor

Yeah it is a flaky test: istio/istio#18756. Should not block this PR.

@bianpengyuan
Copy link
Contributor

/test proxy-presubmit

@lambdai
Copy link
Contributor Author

lambdai commented Nov 7, 2019

Passing at my machine. I think it's flaky. Retry

@istio-testing istio-testing merged commit 4d3cebb into istio:release-1.4 Nov 7, 2019
@lambdai lambdai deleted the listenerfilterto branch November 8, 2019 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants