Add mixer interface in api manager.#25
Merged
chowchow316 merged 3 commits intoistio:masterfrom Jan 3, 2017
Merged
Conversation
lizan
approved these changes
Jan 3, 2017
qiwzhang
reviewed
Jan 3, 2017
| // Basic information about the API call (operation). | ||
| struct OperationInfo { | ||
| // The service name | ||
| ::google::protobuf::StringPiece service_name; |
Contributor
There was a problem hiding this comment.
This will not change. We don't want to pass in for each request. We can store it in Mixer class, pass it into in Mixer::Create()
| std::string request_body; | ||
| request.SerializeToString(&request_body); | ||
|
|
||
| grpc_request->set_service("istio.mixer.v1.Mixer") |
Contributor
There was a problem hiding this comment.
call set_server("mixer_server").
qiwzhang
reviewed
Jan 3, 2017
| virtual utils::Status Close(); | ||
|
|
||
| virtual utils::Status GetStatistics(service_control::Statistics* stat) const; | ||
| const std::string& service_name() const { return service_name_; } |
Contributor
There was a problem hiding this comment.
this getter is not needed.
| ::istio::mixer::v1::CheckRequest request; | ||
| request.set_request_index(++request_index_); | ||
| CovertToPb(info, request.mutable_attribute_update()); | ||
| CovertToPb(info, service_name(), request.mutable_attribute_update()); |
Contributor
There was a problem hiding this comment.
Just use service_name_ directly.
Contributor
Author
There was a problem hiding this comment.
Do you mean treat service_name_ as public variable?
Contributor
There was a problem hiding this comment.
no. service_name_ is a private. Mixer::Check() should be able to use it directly.
qiwzhang
approved these changes
Jan 3, 2017
chowchow316
added a commit
that referenced
this pull request
Jan 30, 2017
* Add mixer interface in api manager. * Store service_name in mixer class. * Remove getter function for service_name.
qiwzhang
added a commit
that referenced
this pull request
Feb 16, 2018
dcillera
pushed a commit
to dcillera/proxy-1
that referenced
this pull request
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.