Skip to content

Update envoy SHA to dfec97814ae912d5b3188e85be400dbd343cdbf0#2453

Closed
nrjpoddar wants to merge 1 commit intoistio:release-1.3from
nrjpoddar:release-17139
Closed

Update envoy SHA to dfec97814ae912d5b3188e85be400dbd343cdbf0#2453
nrjpoddar wants to merge 1 commit intoistio:release-1.3from
nrjpoddar:release-17139

Conversation

@nrjpoddar
Copy link
Member

No description provided.

@nrjpoddar nrjpoddar requested a review from a team October 10, 2019 18:18
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 10, 2019
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 10, 2019
Copy link
Contributor

@rlenglet rlenglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nrjpoddar!
I would like to also pick istio/envoy#111 in the 1.3.3 release, which hasn't been merged yet.
Let's do a single PR to update the SHA for the release.

Copy link
Contributor

@rlenglet rlenglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm changing my mind, let's get this merged anyway.
But no need to change the istio/proxy SHA in istio/istio until istio/envoy#111 is merged and picked in istio/proxy.

@rlenglet
Copy link
Contributor

@nrjpoddar Please add an item in the 1.3.3 release note draft for istio/envoy#109 in layman terms.

@nrjpoddar
Copy link
Member Author

@nrjpoddar Please add an item in the 1.3.3 release note draft for istio/envoy#109 in layman terms.

yes, thanks for reminding and making sure it's in layman lingo. Cheers! :)

@nrjpoddar
Copy link
Member Author

@rlenglet took a stab at the Release Notes: https://github.com/istio/istio/wiki/Release-Note-1.3.3-Draft

Feel free to augment it if it's still unclear or too complex.

@rlenglet
Copy link
Contributor

That looks great, thank!

@rlenglet
Copy link
Contributor

rlenglet commented Oct 10, 2019

We can close this PR. #2455 will be merged. It picks up a more recent istio/envoy:release-1.3 SHA.

@rlenglet rlenglet closed this Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants