Add check_style in presubmit test.#23
Merged
qiwzhang merged 8 commits intoistio:masterfrom Dec 29, 2016
Merged
Conversation
Contributor
|
https://travis-ci.org/istio/proxy/builds/187358770 Seems travis doesn't have required version of |
lizan
suggested changes
Dec 29, 2016
| echo "Current version: ${CLANG_VERSION}" | ||
| CLANG_DIRECTORY=$(mktemp -d /tmp/clang_XXXXX) | ||
| echo "Installing required clang-format ${CLANG_VERSION_REQUIRED} to ${CLANG_DIRECTORY}" | ||
| curl --silent --show-error --retry 10 \ |
Contributor
There was a problem hiding this comment.
Cache the installation?
https://github.com/istio/proxy/blob/master/.travis.yml
script/check-style
Outdated
| CLANG_DIRECTORY=$(mktemp -d /tmp/clang_XXXXX) | ||
| echo "Installing required clang-format ${CLANG_VERSION_REQUIRED} to ${CLANG_DIRECTORY}" | ||
| curl --silent --show-error --retry 10 \ | ||
| "http://releases.llvm.org/${CLANG_VERSION_REQUIRED}/clang+llvm-${CLANG_VERSION_REQUIRED}-x86_64-linux-gnu-debian8.tar.xz" \ |
Contributor
There was a problem hiding this comment.
our Travis uses Ubuntu Xenial (16.04), so this should be: http://releases.llvm.org/3.8.0/clang+llvm-3.8.0-x86_64-linux-gnu-ubuntu-16.04.tar.xz
lizan
reviewed
Dec 29, 2016
| CLANG_DIRECTORY=$(mktemp -d /tmp/clang_XXXXX) | ||
| echo "Installing required clang-format ${CLANG_VERSION_REQUIRED} to ${CLANG_DIRECTORY}" | ||
| curl --silent --show-error --retry 10 \ | ||
| "http://releases.llvm.org/${CLANG_VERSION_REQUIRED}/clang+llvm-${CLANG_VERSION_REQUIRED}-x86_64-linux-gnu-ubuntu-14.04.tar.xz" \ |
lizan
approved these changes
Dec 29, 2016
chowchow316
pushed a commit
that referenced
this pull request
Jan 30, 2017
* Add check_style in presubmit test. * Checks clang-format version. * Install required clang-fromat version. * Download the clang-format for ubuntu. * Cache the clang-format folder. * Use ubuntu 16.4 * Revert ubuntu version back to 14.04. * Make sure clang-format can be run.
fpesce
pushed a commit
that referenced
this pull request
Jun 11, 2020
* [1.5] upate envoy SHA Signed-off-by: Yuchen Dai <silentdai@gmail.com> * hacking gernatewasm Signed-off-by: Yuchen Dai <silentdai@gmail.com> * revert istio-private Signed-off-by: Yuchen Dai <silentdai@gmail.com>
dcillera
added a commit
to dcillera/proxy-1
that referenced
this pull request
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.