Resolve CI failing: remove bazel shutdown command#2209
Merged
istio-testing merged 1 commit intoistio:masterfrom May 10, 2019
Merged
Resolve CI failing: remove bazel shutdown command#2209istio-testing merged 1 commit intoistio:masterfrom
istio-testing merged 1 commit intoistio:masterfrom
Conversation
googlebot
added
the
cla: yes
Contributor
|
/lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huang195, lizan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yxue
pushed a commit
to yxue/proxy
that referenced
this pull request
May 29, 2019
yxue
pushed a commit
to yxue/proxy
that referenced
this pull request
May 29, 2019
duderino
pushed a commit
that referenced
this pull request
May 29, 2019
Member
Author
|
@duderino Getting rid of bazel shutdown fixed the timeout problem, but also exposed another problem that's caused by a newer version of bazel (0.25?) that's pulled in by brew. You probably need to pull a subset of changes from this PR to completely fix macos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lizan this is the simpler version of the PR here: #2203.
This should at least pass all the
requiredCI use cases. /ptal