Skip to content

[BOT PR] to update dependencies of proxy#2202

Closed
istio-testing wants to merge 1 commit intomasterfrom
autoUpdateDeps_3a49cd3c8e5d4ea13afd2bb9f5506a3f
Closed

[BOT PR] to update dependencies of proxy#2202
istio-testing wants to merge 1 commit intomasterfrom
autoUpdateDeps_3a49cd3c8e5d4ea13afd2bb9f5506a3f

Conversation

@istio-testing
Copy link
Collaborator

This PR will NOT be merged automatically once checks are successful. NEEDS approval from OWNERS.

none

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label May 7, 2019
@istio-testing
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: istio-testing
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: venilnoronha

If they are not already assigned, you can assign the PR to them by writing /assign @venilnoronha in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@huang195
Copy link
Member

huang195 commented May 7, 2019

@duderino @utka It looks like istio/proxy has been having build issues since #2181. This is preventing changes from istio/api making its way to this repo. Can one the owners please take a look at this?

As far as I can see, this has been going on for more than 2 weeks.

@utka
Copy link
Contributor

utka commented May 7, 2019

#2181 is for release 1.1 branch, this one is for master

@huang195
Copy link
Member

huang195 commented May 7, 2019

@utka ah i missed that. But regardless, CI has been failing on all PRs in the last few weeks. Is it a problem with CI itself or something else?

@huang195
Copy link
Member

huang195 commented May 7, 2019

So I just created a circleCI account to build istio/proxy by first forking it to my own repo huang195/proxy, and manually triggered the build. My thought at first is the head of the master branch should pass CI, but it doesn't. You can see it here: https://circleci.com/gh/huang195/proxy/3. It gives the same error message as in all these PRs here.

I tried to manually run the CI build locally by following the steps here: https://github.com/istio/proxy/blob/master/.circleci/config.yml, and I didn't see any problems in my local build. Is there a problem with circleCI's build environment or something changed on their side?

@istio-testing istio-testing deleted the autoUpdateDeps_3a49cd3c8e5d4ea13afd2bb9f5506a3f branch May 8, 2019 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. dependency-update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants