Skip to content

Retrieve tracing header from request headers during report#2197

Merged
istio-testing merged 7 commits intoistio:masterfrom
bianpengyuan:tracing-header-master
May 17, 2019
Merged

Retrieve tracing header from request headers during report#2197
istio-testing merged 7 commits intoistio:masterfrom
bianpengyuan:tracing-header-master

Conversation

@bianpengyuan
Copy link
Contributor

Port 1.1 PR (#2182) into master. Fixes istio/istio#13391.

@istio-testing istio-testing requested review from qiwzhang and utka May 3, 2019 01:14
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label May 3, 2019
@bianpengyuan
Copy link
Contributor Author

/retest

@bianpengyuan bianpengyuan force-pushed the tracing-header-master branch from 208cd98 to a07297f Compare May 17, 2019 18:53
@bianpengyuan
Copy link
Contributor Author

@kyessenov @mandarjog Can I get a lgtm? Thx!

Copy link
Contributor

@kyessenov kyessenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bianpengyuan, kyessenov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit a6961e1 into istio:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mixer-based tracing with zipkin adapter doesn't work properly with 1.1.2

4 participants