Skip to content

Send delta metrics for intermediate reports. #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chowchow316 merged 4 commits into from
Apr 7, 2017
Merged

Send delta metrics for intermediate reports. #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cded6f3
Send delta metrics for intermediate reports.
chowchow316 Apr 6, 2017
3366f85
Move last_request_bytes/last_response_bytes to RequestContext.
chowchow316 Apr 6, 2017
bf59cdd
Handle final report.
chowchow316 Apr 6, 2017
16d4091
Address comment.
chowchow316 Apr 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions contrib/endpoints/src/api_manager/context/request_context.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@ RequestContext::RequestContext(std::shared_ptr<ServiceContext> service_context,
std::unique_ptr<Request> request)
: service_context_(service_context),
request_(std::move(request)),
is_first_report_(true) {
is_first_report_(true),
last_request_bytes_(0),
last_response_bytes_(0) {
start_time_ = std::chrono::system_clock::now();
last_report_time_ = std::chrono::steady_clock::now();
operation_id_ = GenerateUUID();
Expand Down Expand Up @@ -267,13 +269,23 @@ void RequestContext::FillReportRequestInfo(
info->auth_audience = auth_audience_;

if (!info->is_final_report) {
info->request_bytes = request_->GetGrpcRequestBytes();
info->response_bytes = request_->GetGrpcResponseBytes();
// Make sure we send delta metrics for intermediate reports.
info->request_bytes = request_->GetGrpcRequestBytes() - last_request_bytes_;
info->response_bytes =
request_->GetGrpcResponseBytes() - last_response_bytes_;
last_request_bytes_ += info->request_bytes;
last_response_bytes_ += info->response_bytes;
} else {
info->request_size = response->GetRequestSize();
info->response_size = response->GetResponseSize();
info->request_bytes = info->request_size;
info->response_bytes = info->response_size;
info->request_bytes = info->request_size - last_request_bytes_;
if (info->request_bytes < 0) {
info->request_bytes = 0;
}
info->response_bytes = info->response_size - last_response_bytes_;
if (info->response_bytes < 0) {
info->response_bytes = 0;
}

info->streaming_request_message_counts =
request_->GetGrpcRequestMessageCounts();
Expand Down
4 changes: 4 additions & 0 deletions contrib/endpoints/src/api_manager/context/request_context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,10 @@ class RequestContext {

// The time point of last intermediate report
std::chrono::steady_clock::time_point last_report_time_;

// The accumulated data sent till last intermediate report
int64_t last_request_bytes_;
int64_t last_response_bytes_;
};

} // namespace context
Expand Down