merge release-1.1 to master by lizan · Pull Request #2152 · istio/proxy

lizan · 2019-03-13T01:20:53Z

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

None

…stio#2097) * WIP * add local and override tests * revert attributes_builder * white list forward attributes * add tests with whitelist * fix builder test for white listed attributes

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

* Add flag indicating current semantics of report batch * Fix Unit Test

…tio#2109) * Update Envoy SHA to latest with deterministic hash (release-1.1). Signed-off-by: Piotr Sikora <piotrsikora@google.com> * review: use lld linker for clang-asan and clang-tsan. Signed-off-by: Piotr Sikora <piotrsikora@google.com> * review: export PATH. Signed-off-by: Piotr Sikora <piotrsikora@google.com>

@PiotrSikora

…2105) This is a load generator client + origin server I created to test the Mixer filter under various fault conditions using Envoy's client and server stacks. This work falls under [istio/istio#8224](istio/istio#8224) @PiotrSikora @jplevyak would love your feedback because it could be used for the wasm work and especially because this is the first >=C++11 code I've written See test/integration/int_client_server_test.cc if you want to start with an example for context. Another example that uses this framework to sandwich Envoy+Mixer filter between the load generator and multiple origin servers simulating Mixer servers can be found in [istio/istio#8224](istio/istio#8224)

…ICT mode (istio#2114) * Warn user of using mTLS PERMISSIVE mode and suggest to upgrade to STRICT mode. Signed-off-by: Yangmin Zhu <ymzhu@google.com> * fix format * check in constructor

* Update to latest istio/api on release-1.1 branch * Update istio/api to latest release-1.1

…to envoy logs. (istio#2116) * Added simple logging abstraction so mixer client logs can be relayed to envoy logs when running inside envoy, stderr when running standalone. * Log threshold guards that prevent needless serialization of logging arguments are now embedded in the log macros. * Format * Added do/while guards around logging statements.

…o#2117) * Coalesce all memory for policy check requests and telemetry reports into shared pointers that live as long as a request's mixer filter instance. * A few small fixups for the code review. * Address some minor nits from code review.

* Coalesce all memory for policy check requests and telemetry reports into shared pointers that live as long as a request's mixer filter instance. * A few small fixups for the code review. * Added finer-grained counters to mixer policy check

* Add configurable retry to policy/quota checks that failed due to transport error. * Added assertions on mixer filter stats to mixer fault test. * Reformat * Fix inaccurate comment. ` * Fix asan warning (thanks @silentdai!) and exclude mixer_fault_test from the asan and tsan sanitizers since it always times out. * Fix bad prefix check

* log authn permissive mode only when config is received Signed-off-by: Yangmin Zhu <ymzhu@google.com> * fix format * fix build

* compiler barking Signed-off-by: Kuat Yessenov <kuat@google.com> * piotrs fix Signed-off-by: Kuat Yessenov <kuat@google.com>

* Added counters to track telemetry report result. * reformat * replace tabs with spaces * Replace more tab with spaces.

Signed-off-by: Kuat Yessenov <kuat@google.com>

) * Deflake macos MixerFaultTest by broadening assertion ranges. Fix flake in macos tests that was introduced by istio#2113 * Cleanup a few readability issues and add an assertion. * More redability changes.

This reverts commit d857bdd.

* API sha for proxy * API sha for proxy

…merge

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

googlebot · 2019-03-13T01:21:10Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

venilnoronha

/lgtm
/approve

istio-testing · 2019-03-13T01:21:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lizan, venilnoronha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [lizan,venilnoronha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

googlebot · 2019-03-13T01:22:29Z

☹️ Sorry, but only Googlers may change the label cla: yes.

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

rshriram · 2019-03-13T02:02:45Z

fix build

lizan · 2019-03-14T00:53:46Z

@duderino mixer_fault_test is failing like this:

[ RUN      ] MixerFaultTest.RetryOnTransportError
test/integration/mixer_fault_test.cc:1004: Failure
Expected equality of these values:
  counters["http_mixer_filter.total_remote_call_other_errors"]
    Which is: 450
  0
test/integration/mixer_fault_test.cc:1020: Failure
Expected: (counters["http_mixer_filter.total_remote_call_send_errors"]) >= (requests_to_send / 2 - requests_to_send / 10), actual: 0 vs 360
[  FAILED  ] MixerFaultTest.RetryOnTransportError (7574 ms)

Any idea?

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

lizan · 2019-03-14T01:09:18Z

@duderino ok it should be now fixed, can you modify CLA?

kyessenov · 2019-03-14T20:16:40Z

Apologize, misread the git history.

mandarjog and others added 27 commits January 30, 2019 11:35

Forwarded attributes override statically configured Local Attributes (i…

b6b4b5d

…stio#2097) * WIP * add local and override tests * revert attributes_builder * white list forward attributes * add tests with whitelist * fix builder test for white listed attributes

ignore istio.mixer in report (istio#2098)

95bec11

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

whitelist kSourceNamespace attribute (istio#2100)

1ae5ab2

Add flag indicating current semantics of report batch (istio#2111)

3509b29

* Add flag indicating current semantics of report batch * Fix Unit Test

Warn user of using mTLS PERMISSIVE mode and suggest to upgrade to STR…

879f8d5

…ICT mode (istio#2114) * Warn user of using mTLS PERMISSIVE mode and suggest to upgrade to STRICT mode. Signed-off-by: Yangmin Zhu <ymzhu@google.com> * fix format * check in constructor

Update to latest istio/api on release-1.1 branch (istio#2115)

ea5e8af

* Update to latest istio/api on release-1.1 branch * Update istio/api to latest release-1.1

Pull in latest istio/api from release-1.1 branch (istio#2120)

fc273e1

Add Joshua into proxy OWNER (istio#2121)

97d17a5

log authn permissive mode only when config is received (istio#2125)

9d6f2d3

* log authn permissive mode only when config is received Signed-off-by: Yangmin Zhu <ymzhu@google.com> * fix format * fix build

clang-6/gcc: compiler barking fix (istio#2123)

b116ee7

* compiler barking Signed-off-by: Kuat Yessenov <kuat@google.com> * piotrs fix Signed-off-by: Kuat Yessenov <kuat@google.com>

Add additional telemetry report counters (istio#2128)

c442767

* Added counters to track telemetry report result. * reformat * replace tabs with spaces * Replace more tab with spaces.

New api sha for proxy (istio#2130)

d2073ed

API sha just changed, chanign it again for proxy (istio#2131)

0b0d2c5

implement upstream secure bit (istio#2133)

d857bdd

Signed-off-by: Kuat Yessenov <kuat@google.com>

Deflake macos MixerFaultTest by broadening assertion ranges. (istio#2126

d93b2a8

) * Deflake macos MixerFaultTest by broadening assertion ranges. Fix flake in macos tests that was introduced by istio#2113 * Cleanup a few readability issues and add an assertion. * More redability changes.

API sha for proxy (istio#2136)

1962d52

Revert "implement upstream secure bit (istio#2133)" (istio#2135)

f95f853

This reverts commit d857bdd.

Rc3. new API sha for proxy. (istio#2146)

9d0bda2

* API sha for proxy * API sha for proxy

Building 1.1rc4 (istio#2150)

8ddb2aa

Merge remote-tracking branch 'upstream/release-1.1' into release-1.1_…

d86401d

…merge

fix build

4db5030

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

istio-testing requested review from rshriram and venilnoronha March 13, 2019 01:20

istio-testing added the approved label Mar 13, 2019

googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Mar 13, 2019

venilnoronha approved these changes Mar 13, 2019

View reviewed changes

istio-testing assigned venilnoronha Mar 13, 2019

istio-testing added the lgtm label Mar 13, 2019

venilnoronha added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Mar 13, 2019

googlebot removed the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 13, 2019

lizan mentioned this pull request Mar 13, 2019

add upstream_transport_failure_reason to access log istio/istio#12434

Merged

fix format

15924b9

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Mar 13, 2019

fix status match

8a78e03

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

rshriram merged commit ecbd173 into istio:master Mar 14, 2019

lizan deleted the release-1.1_merge branch March 14, 2019 20:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

merge release-1.1 to master#2152

merge release-1.1 to master#2152
rshriram merged 29 commits intoistio:masterfrom
lizan:release-1.1_merge

lizan commented Mar 13, 2019

Uh oh!

googlebot commented Mar 13, 2019

Uh oh!

venilnoronha left a comment

Uh oh!

istio-testing commented Mar 13, 2019

Uh oh!

googlebot commented Mar 13, 2019

Uh oh!

rshriram commented Mar 13, 2019

Uh oh!

lizan commented Mar 14, 2019

Uh oh!

lizan commented Mar 14, 2019

Uh oh!

kyessenov commented Mar 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Conversation

lizan commented Mar 13, 2019

Uh oh!

googlebot commented Mar 13, 2019

Uh oh!

venilnoronha left a comment

Choose a reason for hiding this comment

Uh oh!

istio-testing commented Mar 13, 2019

Uh oh!

googlebot commented Mar 13, 2019

Uh oh!

rshriram commented Mar 13, 2019

Uh oh!

lizan commented Mar 14, 2019

Uh oh!

lizan commented Mar 14, 2019

Uh oh!

kyessenov commented Mar 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants