Skip to content

clang-6/gcc: compiler barking fix #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
duderino merged 2 commits into from
Feb 22, 2019
Merged

clang-6/gcc: compiler barking fix #2123

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8845897
compiler barking
kyessenov Feb 20, 2019
486f89a
piotrs fix
kyessenov Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/envoy/http/mixer/control_factory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ class ControlFactory : public Logger::Loggable<Logger::Id::config> {
case istio::utils::Logger::Level::ERROR_:
return ENVOY_LOG_CHECK_LEVEL(error);

@PiotrSikora PiotrSikora Feb 21, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

default:
  NOT_REACHED_GCOVR_EXCL_LINE;

is more in line with Envoy's coding style, and it should fix this as well.

@kyessenov kyessenov Feb 21, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}
return false;
}

virtual void writeBuffer(istio::utils::Logger::Level level,
Expand Down