Merged
Conversation
lizan
approved these changes
Dec 28, 2016
Contributor
Author
|
Changed the condition to get latency info. PTAL. |
qiwzhang
reviewed
Dec 28, 2016
| FillLogMessage(info); | ||
| if(method() && !method()->request_streaming() && !method()->response_streaming()) { | ||
| bool is_streaming = false; | ||
| if(method() && (method()->request_streaming() || method()->response_streaming())) { |
Contributor
There was a problem hiding this comment.
could you do a lint format (clang-format) for this change?
qiwzhang
approved these changes
Dec 28, 2016
chowchow316
added a commit
that referenced
this pull request
Jan 30, 2017
jacob-delgado
pushed a commit
that referenced
this pull request
Jun 11, 2020
* [1.6] Update envoy SHA (#21) Signed-off-by: Yuchen Dai <silentdai@gmail.com> * hacking generate-wasm Signed-off-by: Yuchen Dai <silentdai@gmail.com> * avoid define envoy_project Signed-off-by: Yuchen Dai <silentdai@gmail.com> * revert generate-wasm, and istio-private Signed-off-by: Yuchen Dai <silentdai@gmail.com> * allow wasm_include running under istio-private Signed-off-by: Yuchen Dai <silentdai@gmail.com>
istio-testing
pushed a commit
that referenced
this pull request
Jun 12, 2020
* [1.6] Update envoy SHA (#22) * [1.6] Update envoy SHA (#21) Signed-off-by: Yuchen Dai <silentdai@gmail.com> * hacking generate-wasm Signed-off-by: Yuchen Dai <silentdai@gmail.com> * avoid define envoy_project Signed-off-by: Yuchen Dai <silentdai@gmail.com> * revert generate-wasm, and istio-private Signed-off-by: Yuchen Dai <silentdai@gmail.com> * allow wasm_include running under istio-private Signed-off-by: Yuchen Dai <silentdai@gmail.com> * Update WORKSPACE for sha in istio/envoy in release-1.6 branch Co-authored-by: Yuchen Dai <silentdai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.