Skip to content

Update Envoy SHA to latest with protobuf.Any configs.#2081

Merged
istio-testing merged 2 commits intoistio:masterfrom
PiotrSikora:envoy_bbf5674c
Jan 22, 2019
Merged

Update Envoy SHA to latest with protobuf.Any configs.#2081
istio-testing merged 2 commits intoistio:masterfrom
PiotrSikora:envoy_bbf5674c

Conversation

@PiotrSikora
Copy link
Contributor

For istio/istio#10993.

Signed-off-by: Piotr Sikora piotrsikora@google.com

For istio/istio#10993.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 16, 2019
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora
Copy link
Contributor Author

/assign @qiwzhang

@PiotrSikora
Copy link
Contributor Author

Ping.

Copy link
Member

@JimmyCYJ JimmyCYJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve

@JimmyCYJ
Copy link
Member

@PiotrSikora Is this going into master branch or release-1.1 branch?

@JimmyCYJ
Copy link
Member

Is this going into master branch or release-1.1 branch?

Just saw the other PR #2082. Please ignore my question.

@lizan
Copy link
Contributor

lizan commented Jan 18, 2019

/lgtm

Thanks!

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JimmyCYJ, lizan, PiotrSikora

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit eafb657 into istio:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants