Skip to content

rename rbac permissive related attributes key due to envoy recent change #2076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
istio-testing merged 2 commits into from
Jan 8, 2019
Merged

rename rbac permissive related attributes key due to envoy recent change #2076

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3864abe
rename rbac permissive related attributes key due to envoy recent change
quanjielin Jan 7, 2019
d0e5795
rename
quanjielin Jan 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/envoy/http/mixer/report_data.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ namespace Envoy {
namespace Http {
namespace Mixer {
namespace {
const std::string kRbacPermissivePolicyIDField = "shadow_effective_policyID";
const std::string kRbacPermissiveRespCodeField = "shadow_response_code";
const std::string kRbacPermissivePolicyIDField = "shadow_effective_policy_id";
const std::string kRbacPermissiveEngineResultField = "shadow_engine_result";

// Set of headers excluded from response.headers attribute.
const std::set<std::string> ResponseHeaderExclusives = {};
Expand Down Expand Up @@ -135,12 +135,12 @@ class ReportData : public ::istio::control::http::ReportData,

const auto &data_struct = filter_it->second;
const auto resp_code_it =
data_struct.fields().find(kRbacPermissiveRespCodeField);
data_struct.fields().find(kRbacPermissiveEngineResultField);
if (resp_code_it != data_struct.fields().end()) {
report_info->permissive_resp_code = resp_code_it->second.string_value();
} else {
ENVOY_LOG(debug, "No {} field found in filter {} dynamic_metadata",
kRbacPermissiveRespCodeField,
kRbacPermissiveEngineResultField,
Extensions::HttpFilters::HttpFilterNames::get().Rbac);
}

Expand Down