Skip to content

[Cherry-pick] Authenticate an exchanged token (#2070) from the release-1.1 branch#2071

Closed
lei-tang wants to merge 1 commit intoistio:masterfrom
lei-tang:cherry-pick-authn-exchanged-token-to-master
Closed

[Cherry-pick] Authenticate an exchanged token (#2070) from the release-1.1 branch#2071
lei-tang wants to merge 1 commit intoistio:masterfrom
lei-tang:cherry-pick-authn-exchanged-token-to-master

Conversation

@lei-tang
Copy link
Contributor

What this PR does / why we need it: cherry-pick the PR#2070 "Authenticate an exchanged token" from the release-1.1 branch to the master branch. The PR#2070 has been merged into the release-1.1 branch as 0c9e54c.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #2062

Special notes for your reviewer:

Release note:

* Authenticate an exchanged token

* Change issuer name and jwt-authn output with key being original issuer

* Revised the code based on the discussion

* Address review comments and add a test

* Address new review comments

* Add integration tests and address review comments

* Fix a flaky test and address new review comments

* Small grammar fixes

* Revise the function of finding the token header

* Use case-insensitive compare for the header name

* Change the name of a variable

* Revise log statements
@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lei-tang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: lizan

If they are not already assigned, you can assign the PR to them by writing /assign @lizan in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing requested a review from linsun December 21, 2018 08:12
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Dec 21, 2018
@istio-testing
Copy link
Collaborator

@lei-tang: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jan 10, 2019
@JimmyCYJ
Copy link
Member

Do we still need this change? #2078 just merged from release-1.1 into master branch. Is it okay to close the PR? @lei-tang

@lei-tang
Copy link
Contributor Author

@JimmyCYJ Yes, I will close this PR now.

@lei-tang lei-tang closed this Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. needs-rebase Indicates a PR needs to be rebased before being merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Authenticate an exchanged token

4 participants