Handle inflight request canceling properly#2052
Closed
qiwzhang wants to merge 1 commit intoistio:masterfrom
Closed
Handle inflight request canceling properly#2052qiwzhang wants to merge 1 commit intoistio:masterfrom
qiwzhang wants to merge 1 commit intoistio:masterfrom
Conversation
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiwzhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
googlebot
added
the
cla: yes
Contributor
Author
|
@lizan could you take a look? |
Contributor
Author
|
Use #2053 instead of this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wayne Zhang qiwzhang@google.com
While reading Proxy code, found that in-flight request is not canceled properly.
cancel() should be called. Otherwise, if it is called, but memory is freed. it may cause crash
Release note: