Skip to content

Sync with master changes#2011

Closed
rshriram wants to merge 6 commits intoistio:release-1.1from
rshriram:release-1.1
Closed

Sync with master changes#2011
rshriram wants to merge 6 commits intoistio:release-1.1from
rshriram:release-1.1

Conversation

@rshriram
Copy link
Member

Changes:

d06e159 (Shriram Rajagopalan, 63 minutes ago)
bump Envoy SHA to latest
40d927a (Wayne Zhang, 20 hours ago)
Use std::hash for check cache. (#2009)
426eea9 (Lizan Zhou, 30 hours ago)
alts: remove ALTS (#2003)
6e116d5 (Wayne Zhang, 4 days ago)
Improve performance by removing MD5 for check cache keys (#2002)

qiwzhang and others added 6 commits October 26, 2018 16:01
* Improve performance by removing MD5 for check cache keys

Signed-off-by: Wayne Zhang <qiwzhang@google.com>

* not to allocate memory from stack

Signed-off-by: Wayne Zhang <qiwzhang@google.com>

* Make debug string readable

Signed-off-by: Wayne Zhang <qiwzhang@google.com>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram

If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Oct 30, 2018
@rshriram rshriram closed this Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants