Do not report latency for streaming requests.#20
Merged
chowchow316 merged 2 commits intoistio:masterfrom Dec 28, 2016
Merged
Conversation
Contributor
|
It seems that this is not correct. My idea is: here if either request_streaming or response_streaming, not to set Latency. |
chowchow316
force-pushed
the
streaming-latency
branch
from
04a289e to
ccb251d
Compare
Contributor
Author
|
Revert the change in proto.cc, and add change in request_context.cc. PTAL. |
qiwzhang
reviewed
Dec 28, 2016
Contributor
qiwzhang
left a comment
qiwzhang
left a comment
There was a problem hiding this comment.
Do we have streaming t tests to verify this change?
Contributor
Author
|
Yes, we have |
qiwzhang
approved these changes
Dec 28, 2016
chowchow316
added a commit
that referenced
this pull request
Jan 30, 2017
qiwzhang
added a commit
that referenced
this pull request
Feb 16, 2018
* Allocate response buffer. * lint format.
brian-avery
added a commit
that referenced
this pull request
May 12, 2020
* Update Envoy to latest SHA * Fixed
jwendell
added a commit
to jwendell/proxy
that referenced
this pull request
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.