Skip to content

Update Envoy SHA to 8607e912a#1991

Closed
venilnoronha wants to merge 2 commits intoistio:masterfrom
venilnoronha:update-envoy-811ee0d
Closed

Update Envoy SHA to 8607e912a#1991
venilnoronha wants to merge 2 commits intoistio:masterfrom
venilnoronha:update-envoy-811ee0d

Conversation

@venilnoronha
Copy link
Copy Markdown
Member

@venilnoronha venilnoronha commented Oct 15, 2018 •
edited
Loading

What this PR does / why we need it:
This PR updates the Envoy SHA to 8607e912a in order to make the RBAC permissions and other changes available in the Istio Proxy.

Release note:
NONE

@venilnoronha
Update Envoy SHA to 811ee0d
f51836c 
This commit updates the Envoy SHA to
811ee0d in order to make the RBAC
permissions change available in the Istio Proxy.

Signed-off-by: Venil Noronha <veniln@vmware.com>
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 15, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Oct 15, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jimmycyj

If they are not already assigned, you can assign the PR to them by writing /assign @jimmycyj in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JimmyCYJ
Copy link
Copy Markdown
Member

JimmyCYJ commented Oct 15, 2018

I will fix the compile issue in a separate PR.

@venilnoronha
Copy link
Copy Markdown
Member Author

venilnoronha commented Oct 15, 2018

@JimmyCYJ cool, thanks!

@rshriram
Copy link
Copy Markdown
Member

rshriram commented Oct 15, 2018

Venil, can you also update to the latest sha again to include the PR that recently merged?

@venilnoronha
Update Envoy SHA to 8607e91
cc1fa51 
Signed-off-by: Venil Noronha <veniln@vmware.com>
@venilnoronha venilnoronha changed the title Update Envoy SHA to 811ee0dc Update Envoy SHA to 8607e912a Oct 15, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Oct 15, 2018

@venilnoronha: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/proxy-presubmit-asan.sh cc1fa51 link /test proxy-presubmit-asan
prow/proxy-presubmit.sh cc1fa51 link /test proxy-presubmit
prow/proxy-presubmit-tsan.sh cc1fa51 link /test proxy-presubmit-tsan
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ
Copy link
Copy Markdown
Member

JimmyCYJ commented Oct 15, 2018 •
edited
Loading

I have created #1993 which solves the build issues with latest Envoy SHA.

@rshriram rshriram closed this Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rshriram rshriram Awaiting requested review from rshriram

@sebastienvas sebastienvas Awaiting requested review from sebastienvas

Assignees

No one assigned

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@venilnoronha @istio-testing @JimmyCYJ @rshriram @googlebot