Skip to content

Retrieve the inner SNI in GetRequestedServerName()#1971

Closed
ronenschafferibm wants to merge 2 commits intoistio:release-1.0from
ronenschafferibm:tcp-inner-sni-1.0.2
Closed

Retrieve the inner SNI in GetRequestedServerName()#1971
ronenschafferibm wants to merge 2 commits intoistio:release-1.0from
ronenschafferibm:tcp-inner-sni-1.0.2

Conversation

@ronenschafferibm
Copy link
Contributor

What this PR does / why we need it:
This PR demonstrates a simple possible solution for envoyproxy/envoy#4076
by returning the inner SNI if exists instead of the outer SNI

Which issue this PR fixes
envoyproxy/envoy#4076

Special notes for your reviewer:

Release note:

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Sep 13, 2018
@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sebastienvas

If they are not already assigned, you can assign the PR to them by writing /assign @sebastienvas in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Sep 13, 2018
@istio-testing
Copy link
Collaborator

Hi @ronenschafferibm. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ronenschafferibm ronenschafferibm changed the title [WIP] Retrieve the inner SNI in GetRequestedServerName() Retrieve the inner SNI in GetRequestedServerName() Sep 13, 2018
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants