Skip to content

skip empty SNI#1924

Merged
costinm merged 1 commit intoistio:release-1.0from
vadimeisenbergibm:skip_empty_sni_in_release_1_0
Aug 20, 2018
Merged

skip empty SNI#1924
costinm merged 1 commit intoistio:release-1.0from
vadimeisenbergibm:skip_empty_sni_in_release_1_0

Conversation

@vadimeisenbergibm
Copy link
Contributor

The same as #1909, this PR is to release-1.0.

@istio-testing istio-testing requested a review from JimmyCYJ August 17, 2018 05:22
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Aug 17, 2018
@istio-testing istio-testing requested a review from linsun August 17, 2018 05:22
Copy link
Contributor

@qiwzhang qiwzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiwzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vadimeisenbergibm
Copy link
Contributor Author

@kyessenov Could you please merge this PR?

@kyessenov
Copy link
Contributor

@vadimeisenbergibm I'm not an admin. Please seek TOC or @costinm .

@vadimeisenbergibm
Copy link
Contributor Author

@costinm Could you please merge this PR to be included for release-1.0.1? (Customer issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants