Skip to content

add debug logs for collecting rbac attributes #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
istio-testing merged 1 commit into from
Aug 15, 2018
Merged

add debug logs for collecting rbac attributes #1922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/envoy/http/mixer/report_data.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

#pragma once

#include "common/common/logger.h"
#include "common/request_info/utility.h"
#include "envoy/http/header_map.h"
#include "envoy/request_info/request_info.h"
Expand Down Expand Up @@ -48,7 +49,8 @@ bool ExtractGrpcStatus(const HeaderMap *headers,

} // namespace

class ReportData : public ::istio::control::http::ReportData {
class ReportData : public ::istio::control::http::ReportData,
public Logger::Loggable<Logger::Id::filter> {
const HeaderMap *headers_;
const HeaderMap *trailers_;
const RequestInfo::RequestInfo &info_;
Expand Down Expand Up @@ -125,6 +127,8 @@ class ReportData : public ::istio::control::http::ReportData {
const auto filter_it =
filter_meta.find(Extensions::HttpFilters::HttpFilterNames::get().Rbac);
if (filter_it == filter_meta.end()) {
ENVOY_LOG(debug, "No dynamic_metadata found for filter {}",
Extensions::HttpFilters::HttpFilterNames::get().Rbac);
return false;
}

Expand All @@ -133,12 +137,20 @@ class ReportData : public ::istio::control::http::ReportData {
data_struct.fields().find(kRbacPermissiveRespCodeField);
if (resp_code_it != data_struct.fields().end()) {
report_info->permissive_resp_code = resp_code_it->second.string_value();
} else {
ENVOY_LOG(debug, "No {} field found in filter {} dynamic_metadata",
kRbacPermissiveRespCodeField,
Extensions::HttpFilters::HttpFilterNames::get().Rbac);
}

const auto policy_id_it =
data_struct.fields().find(kRbacPermissivePolicyIDField);
if (policy_id_it != data_struct.fields().end()) {
report_info->permissive_policy_id = policy_id_it->second.string_value();
} else {
ENVOY_LOG(debug, "No {} field found in filter {} dynamic_metadata",
kRbacPermissivePolicyIDField,
Extensions::HttpFilters::HttpFilterNames::get().Rbac);
}

return !report_info->permissive_resp_code.empty() ||
Expand Down