Merged
Conversation
kyessenov
approved these changes
Dec 22, 2016
Contributor
kyessenov
left a comment
kyessenov
left a comment
There was a problem hiding this comment.
Looks good for a prototype.
Please fix the build error first.
chowchow316
requested review from
geeknoid and
lizan
and removed request for
geeknoid
lizan
suggested changes
Dec 22, 2016
src/envoy/repositories.bzl
Outdated
| "source/common/version_generated.cc", | ||
| ], | ||
| copts = [ | ||
| "-I./external/envoy_git/include", |
Contributor
There was a problem hiding this comment.
remove this line if you added includes below
src/envoy/repositories.bzl
Outdated
| "source/**/*.h", | ||
| "include/**/*.h", | ||
| ], exclude=["source/exe/main.cc"]) + [ | ||
| ]) + [ |
Contributor
There was a problem hiding this comment.
removing this exclusion will fail the test.
Add a cc_library
cc_library(
name = "envoy-main",
srcs = [
"source/exe/main.cc",
],
deps = [
":envoy-common",
]
)
and depends on it from the prototype.
geeknoid
approved these changes
Dec 22, 2016
lizan
approved these changes
Dec 22, 2016
chowchow316
added a commit
that referenced
this pull request
Jan 30, 2017
qiwzhang
added a commit
that referenced
this pull request
Feb 16, 2018
howardjohn
pushed a commit
that referenced
this pull request
May 12, 2020
kyessenov
pushed a commit
to kyessenov/proxy
that referenced
this pull request
Aug 8, 2022
fix eds dedupe
jwendell
added a commit
to jwendell/proxy
that referenced
this pull request
Jun 2, 2025
* Automator: update envoy@ in istio/proxy@release-1.24 (istio#6192) * Automator: update envoy@ in istio/proxy@release-1.24 (istio#6199) * Automator: update envoy@ in istio/proxy@release-1.24 (istio#6203) * Automator: update envoy@ in istio/proxy@release-1.24 (istio#6208) * Automator: update common-files@release-1.24 in istio/proxy@release-1.24 (istio#6226) * Automator: update envoy@ in istio/proxy@release-1.24 (istio#6234) * Bump Envoy and dependencies --------- Co-authored-by: Istio Automation <istio-testing-bot@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved envoy branch here from gcp-apis/esp. Will add mixer interface later.