Skip to content

Improve build times on CircleCI. #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rshriram merged 1 commit into from
Jul 25, 2018
Merged

Improve build times on CircleCI. #1875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 51 additions & 16 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,54 +12,89 @@ jobs:
- checkout
- restore_cache:
keys:
- bazel-cache-{{ checksum "WORKSPACE" }}
- restore_cache:
keys:
- repo-cache-{{ checksum "WORKSPACE" }}
- linux_fastbuild-bazel-cache-{{ checksum "WORKSPACE" }}
# To build docker containers or run tests in a docker
- setup_remote_docker
- run: rm ~/.gitconfig
- run: make check
- run: make deb BAZEL_BUILD_ARGS="-j 4"
- run: make deb
- run: make test
- run: make test_asan
- run: make test_tsan
- save_cache:
key: repo-cache-{{ checksum "WORKSPACE" }}
paths:
- /home/circleci/.repo
- save_cache:
key: bazel-cache-{{ checksum "WORKSPACE" }}
key: linux_fastbuild-bazel-cache-{{ checksum "WORKSPACE" }}
paths:
- /home/circleci/.cache/bazel
- store_artifacts:
path: /home/circleci/project/bazel-bin/tools/deb/istio-proxy.deb
destination: /proxy/deb
- store_artifacts:
path: /home/circleci/project/bazel-bin/src/envoy/mixer/envoy
path: /home/circleci/project/bazel-bin/src/envoy/envoy
destination: /proxy/bin
linux_asan:
docker:
- image: istio/ci:go1.9-bazel0.11
environment:
- BAZEL_TEST_ARGS: "--test_env=ENVOY_IP_TEST_VERSIONS=v4only --test_output=all"
resource_class: xlarge
steps:
- run: sudo apt-get update && sudo apt-get install -y pkg-config
- checkout
- restore_cache:
keys:
- linux_asan-bazel-cache-{{ checksum "WORKSPACE" }}
# To build docker containers or run tests in a docker
- setup_remote_docker
- run: rm ~/.gitconfig
- run: make test_asan
- save_cache:
key: linux_asan-bazel-cache-{{ checksum "WORKSPACE" }}
paths:
- /home/circleci/.cache/bazel
linux_tsan:
docker:
- image: istio/ci:go1.9-bazel0.11
environment:
- BAZEL_TEST_ARGS: "--test_env=ENVOY_IP_TEST_VERSIONS=v4only --test_output=all"
resource_class: xlarge
steps:
- run: sudo apt-get update && sudo apt-get install -y pkg-config
- checkout
- restore_cache:
keys:
- linux_tsan-bazel-cache-{{ checksum "WORKSPACE" }}
# To build docker containers or run tests in a docker
- setup_remote_docker
- run: rm ~/.gitconfig
- run: make test_tsan
- save_cache:
key: linux_tsan-bazel-cache-{{ checksum "WORKSPACE" }}
paths:
- /home/circleci/.cache/bazel
macos:
macos:
xcode: "9.3.0"
environment:
- BAZEL_STARTUP_ARGS: "--output_base /Users/distiller/.cache/bazel"
Copy link
Member

@rshriram rshriram Jul 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who is distiller?

Copy link
Contributor Author

@PiotrSikora PiotrSikora Jul 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the name of the CircleCI's user account on macOS.

- BAZEL_TEST_ARGS: "--test_env=ENVOY_IP_TEST_VERSIONS=v4only --test_output=all"
steps:
- run: sudo ntpdate -vu time.apple.com
- run: brew install automake bazel cmake coreutils go libtool wget
- checkout
- restore_cache:
keys:
- bazel-cache-{{ checksum "WORKSPACE" }}-macos
- macos_fastbuild_v2-bazel-cache-{{ checksum "WORKSPACE" }}
- run: rm ~/.gitconfig
- run: make build_envoy
- run: make test
- save_cache:
key: bazel-cache-{{ checksum "WORKSPACE" }}-macos
key: macos_fastbuild_v2-bazel-cache-{{ checksum "WORKSPACE" }}
paths:
- /home/circleci/.cache/bazel
- /Users/distiller/.cache/bazel

workflows:
version: 2
all:
jobs:
- build
- linux_asan
- linux_tsan
- macos
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ build:

# Build only envoy - fast
build_envoy:
bazel $(BAZEL_STARTUP_ARGS) build $(BAZEL_BUILD_ARGS) //src/envoy/mixer:envoy
bazel $(BAZEL_STARTUP_ARGS) build $(BAZEL_BUILD_ARGS) //src/envoy:envoy

clean:
@bazel clean
Expand All @@ -50,7 +50,7 @@ artifacts: build
@script/push-debian.sh -c opt -p $(ARTIFACTS_DIR)

deb:
@bazel build tools/deb:istio-proxy ${BAZEL_BUILD_ARGS}
@bazel $(BAZEL_STARTUP_ARGS) build $(BAZEL_BUILD_ARGS) //tools/deb:istio-proxy


.PHONY: build clean test check artifacts