add connection.requested_server_name to tcp and http filters#1848
Merged
hklai merged 6 commits intoistio:release-1.0from Jul 11, 2018
vadimeisenbergibm:add_connection_requested_server_name_attribute_take3
Merged
add connection.requested_server_name to tcp and http filters#1848hklai merged 6 commits intoistio:release-1.0from vadimeisenbergibm:add_connection_requested_server_name_attribute_take3
hklai merged 6 commits intoistio:release-1.0from
vadimeisenbergibm:add_connection_requested_server_name_attribute_take3
Conversation
googlebot
added
the
cla: yes
vadimeisenbergibm
changed the title
istio-testing
added
the
do-not-merge/work-in-progress
vadimeisenbergibm
changed the title
istio-testing
removed
the
do-not-merge/work-in-progress
Contributor
Author
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hklai, qiwzhang, vadimeisenbergibm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vadimeisenbergibm
added a commit
to vadimeisenbergibm/istio
that referenced
this pull request
Jul 11, 2018
hklai
pushed a commit
to istio/istio
that referenced
this pull request
Jul 11, 2018
* add connection.requested_server_name attribute * add requestedServerName to accesslog logentry * add requestedServerName to tcp access log * remove redundant whitespace * add missing new line at the end of a file * add connection.requested_server_name to test mixer attributes * add requestedServerName to test mixer tcp access log entry * add requestedServerName to test mixer http access log entry * update the SHA of istio/proxy (istio/proxy#1848)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds SNI attribute to the TCP and HTTP filters, to be used in telemetry reports and policy checks. This is a resubmission of a previously merged and reverted PR #1843.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): implements #istio/istio#6810Release note: