Skip to content

[WIP] Add the connection.requested_server_name attribute to the TCP read filter#1847

Closed
vadimeisenbergibm wants to merge 3 commits intoistio:release-1.0from
vadimeisenbergibm:add_connection_requested_server_name_attribute
Closed

[WIP] Add the connection.requested_server_name attribute to the TCP read filter#1847
vadimeisenbergibm wants to merge 3 commits intoistio:release-1.0from
vadimeisenbergibm:add_connection_requested_server_name_attribute

Conversation

@vadimeisenbergibm
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Adds SNI attribute to the TCP read filter, to be used in telemetry reports and policy checks. This is a resubmission of a previously merged and reverted PR #1843.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): implements #istio/istio#6810

Release note:

SNI report and check in TCP filter

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vadimeisenbergibm
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: qiwzhang

Assign the PR to them by writing /assign @qiwzhang in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing requested review from lizan and rshriram July 11, 2018 03:32
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 11, 2018
@vadimeisenbergibm vadimeisenbergibm changed the title Add the connection.requested_server_name attribute to the TCP read filter [WIP] Add the connection.requested_server_name attribute to the TCP read filter Jul 11, 2018
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jul 11, 2018
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jul 11, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

@vadimeisenbergibm: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing
Copy link
Copy Markdown
Collaborator

@vadimeisenbergibm: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/proxy-presubmit-tsan.sh 3e91541 link /test proxy-presubmit-tsan
prow/proxy-presubmit-asan.sh 3e91541 link /test proxy-presubmit-asan
prow/proxy-presubmit.sh 3e91541 link /test proxy-presubmit
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vadimeisenbergibm
Copy link
Copy Markdown
Contributor Author

closing to rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. needs-rebase Indicates a PR needs to be rebased before being merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants