Skip to content

update the API SHA (https://github.com/istio/api/pull/575)#1846

Merged
hklai merged 1 commit intoistio:release-1.0from
vadimeisenbergibm:update_api_sha_294a445476f816ec90e2a6fe2d67968c9d322649
Jul 11, 2018
Merged

update the API SHA (https://github.com/istio/api/pull/575)#1846
hklai merged 1 commit intoistio:release-1.0from
vadimeisenbergibm:update_api_sha_294a445476f816ec90e2a6fe2d67968c9d322649

Conversation

@vadimeisenbergibm
Copy link
Contributor

What this PR does / why we need it:
Part of implementation of istio/istio#6810

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 11, 2018
@istio-testing istio-testing requested review from linsun and rshriram July 11, 2018 02:58
Copy link
Contributor

@hklai hklai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hklai, vadimeisenbergibm
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: lizan

Assign the PR to them by writing /assign @lizan in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hklai hklai merged commit 5aab569 into istio:release-1.0 Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants