Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

Update github.com/envoyproxy/go-control-plane to get transparent socket support#46

Closed
rlenglet wants to merge 1 commit into
istio:masterfrom
isovalent:update-envoyproxy-go-control-plane
Closed

Update github.com/envoyproxy/go-control-plane to get transparent socket support#46
rlenglet wants to merge 1 commit into
istio:masterfrom
isovalent:update-envoyproxy-go-control-plane

Conversation

@rlenglet
Copy link
Copy Markdown

@rlenglet rlenglet commented Mar 30, 2018

Update the github.com/envoyproxy/go-control-plane dependency to get the support for the transparent socket listener flag in LDS, as specified in envoyproxy/data-plane-api#558.

Related: istio/proxy#1338
Required by: istio/istio#4654

Signed-off-by: Romain Lenglet romain@covalent.io

Signed-off-by: Romain Lenglet <romain@covalent.io>
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@rlenglet
Copy link
Copy Markdown
Author

I signed it!

@kyessenov
Copy link
Copy Markdown
Contributor

This might be dupe of #41?
@ldemailly can you also update go-control-plane in your pruning PR?

@rlenglet
Copy link
Copy Markdown
Author

The version of envoyproxy/data-plane-api currently in vendor through envoyproxy/go-control-plane is slightly too old. I need the API change introduced in envoyproxy/data-plane-api#558.

@kyessenov
Copy link
Copy Markdown
Contributor

I think they both point to version 9fdf4bd79736a87c78b3d48b7baa84ea24be1c1a of go-control-plane which has the right API version. Getting vendor in is pretty tricky, since it requires serializing updates. I haven't finished my last update due to some issues, but me or @ldemailly could complete it, and you wouldn't need this PR.

@rlenglet
Copy link
Copy Markdown
Author

@kyessenov OK, my bad, I didn't see that #41 was still open. Thanks!

@ldemailly
Copy link
Copy Markdown
Member

it needs to be done on a branch

@ldemailly ldemailly closed this Mar 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants