This repository was archived by the owner on Jan 16, 2022. It is now read-only.
Add dependency on backoff#38
Closed
ZackButcher wants to merge 1 commit into
Closed
Conversation
geeknoid
previously approved these changes
Mar 23, 2018
Member
|
where are the files? seems you forgot to add them? |
ldemailly
reviewed
Mar 23, 2018
| name = "github.com/golang/glog" | ||
| source = "github.com/istio/glog" | ||
|
|
||
| [[constraint]] |
Member
There was a problem hiding this comment.
this isn't needed, just use it somewhere and make the vendor PR from
make depend.update
it will then show up in the lock file and in the vendor files
Contributor
Author
|
@ldemailly added the files using the make target. I couldn't get the make target to work previously. |
ldemailly
approved these changes
Mar 28, 2018
Member
|
missing |
Contributor
Author
|
Both are in the PR, did I miss something else? |
Contributor
Author
|
See #42 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For istio/istio#4231