Merged
Conversation
howardjohn
reviewed
Dec 16, 2025
Signed-off-by: Ian Rudie <ian.rudie@solo.io>
Signed-off-by: Ian Rudie <ian.rudie@solo.io>
Signed-off-by: Ian Rudie <ian.rudie@solo.io>
Signed-off-by: Ian Rudie <ian.rudie@solo.io>
83d919c to
ea7b148
Compare
Stevenjin8
reviewed
Dec 31, 2025
Signed-off-by: Ian Rudie <ian.rudie@solo.io>
ff96de4 to
7cfedf5
Compare
Signed-off-by: Ian Rudie <ian.rudie@solo.io>
af8e8ba to
1bf38cf
Compare
keithmattix
reviewed
Jan 9, 2026
…ean this up Signed-off-by: Ian Rudie <ian.rudie@solo.io>
stevenctl
reviewed
Jan 9, 2026
Contributor
|
last comment is that we probably want Waypoint to be consistent with the ztunnel logic added in istio/ztunnel#1704 We already get the intra-namespace dedupe logic from the sidecar code (timestamps, service > service entry) but we don't get the "prefer namespace local" that could be added with something like this: https://gist.github.com/stevenctl/9e7aca7e889ddf0970d7d0a60aa438ec |
Signed-off-by: Ian Rudie <ian.rudie@solo.io>
Signed-off-by: Ian Rudie <ian.rudie@solo.io>
Signed-off-by: Ian Rudie <ian.rudie@solo.io>
Signed-off-by: Ian Rudie <ian.rudie@solo.io>
stevenctl
approved these changes
Jan 9, 2026
Contributor
stevenctl
left a comment
There was a problem hiding this comment.
LGTM but can we create a follow up if we want to make waypoint consistent with zt on the "prefer local namespace" case.
keithmattix
approved these changes
Jan 10, 2026
Contributor
|
/retest |
Signed-off-by: Ian Rudie <ian.rudie@solo.io>
Contributor
Author
|
/retest-required |
1 similar comment
Contributor
Author
|
/retest-required |
stevenctl
pushed a commit
to stevenctl/istio
that referenced
this pull request
Jan 14, 2026
* workloadapi changes to add a canonical field to service Signed-off-by: Ian Rudie <ian.rudie@solo.io> * first pass at marking wds services as canonical Signed-off-by: Ian Rudie <ian.rudie@solo.io> * protomarshal.ShallowCopy the wds Service in setCanonical Signed-off-by: Ian Rudie <ian.rudie@solo.io> * precomupute canonical svc, fix logic Signed-off-by: Ian Rudie <ian.rudie@solo.io> * update overlap tests to make assertions about canonical service Signed-off-by: Ian Rudie <ian.rudie@solo.io> * eliminate key conflict requiring checked join Signed-off-by: Ian Rudie <ian.rudie@solo.io> * trying to unravel the issue with MC ambient indexes, we'll need to clean this up Signed-off-by: Ian Rudie <ian.rudie@solo.io> * comment on MapCollection function warning about mapFunc Signed-off-by: Ian Rudie <ian.rudie@solo.io> * cleanup comment Signed-off-by: Ian Rudie <ian.rudie@solo.io> * cleanup repeated code Signed-off-by: Ian Rudie <ian.rudie@solo.io> * sync canonical comment with suggestion from ztunnel PR Signed-off-by: Ian Rudie <ian.rudie@solo.io> * release note Signed-off-by: Ian Rudie <ian.rudie@solo.io> --------- Signed-off-by: Ian Rudie <ian.rudie@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
This is a super early draft for creating "canonical" wds services.
As I worked to optimize ztunnel xds handling and service resolution, it became apparent that the lookup could be optimized all the way to something like, "Is in my namespace ELSE is canonical". When working on "is canonical" it became apparent that this could be a boolean field calculated by istiod instead of a field populated by ztunnel during xds handling.
TODO: