Skip to content

Update dependencies#4601

Closed
kyessenov wants to merge 2 commits into
istio:masterfrom
kyessenov:update-03-28
Closed

Update dependencies#4601
kyessenov wants to merge 2 commits into
istio:masterfrom
kyessenov:update-03-28

Conversation

@kyessenov

Copy link
Copy Markdown
Contributor

Vendor PR istio/old_vendor-istio_repo#41
Signed-off-by: Kuat Yessenov kuat@google.com

@istio-testing

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm

Assign the PR to them by writing /assign @costinm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyessenov kyessenov requested a review from diemtvu March 28, 2018 18:36
@kyessenov

Copy link
Copy Markdown
Contributor Author

Whoa, it fails with no code change?
What gives?

cc on-call @cmluciano

@cmluciano

Copy link
Copy Markdown
Member

May be blocked on #4602

@kyessenov

Copy link
Copy Markdown
Contributor Author

@rshriram @costinm do you have any clue how linter failures ended up on master?

@codecov

codecov Bot commented Mar 28, 2018

Copy link
Copy Markdown

Codecov Report

Merging #4601 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #4601    +/-   ##
=======================================
- Coverage      72%     72%   -<1%     
=======================================
  Files         295     295            
  Lines       25411   25322    -89     
=======================================
- Hits        18230   18158    -72     
+ Misses       6417    6402    -15     
+ Partials      764     762     -2
Impacted Files Coverage Δ
mixer/adapter/prometheus/server.go 97% <0%> (-3%) ⬇️
pilot/pkg/serviceregistry/kube/queue.go 86% <0%> (-3%) ⬇️
pilot/pkg/serviceregistry/kube/controller.go 64% <0%> (-3%) ⬇️
mixer/adapter/servicecontrol/checkprocessor.go 80% <0%> (-2%) ⬇️
mixer/tools/adapterlinter/main.go 89% <0%> (-1%) ⬇️
pilot/pkg/proxy/envoy/v1/ingress.go 78% <0%> (ø) ⬇️
mixer/pkg/attribute/mutableBag.go 100% <0%> (ø) ⬇️
pilot/pkg/networking/v1alpha3/listener.go 0% <0%> (ø) ⬆️
mixer/adapter/dogstatsd/dogstatsd.go 100% <0%> (ø) ⬆️
mixer/adapter/memquota/dedup.go 100% <0%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60653d0...6b4d97f. Read the comment docs.

@kyessenov

Copy link
Copy Markdown
Contributor Author

help please. exclusion doesn't work on circle!

Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
@istio-testing

Copy link
Copy Markdown
Collaborator

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-unit-tests.sh 6b4d97f link /test istio-unit-tests
prow/istio-pilot-e2e-v1alpha3.sh 6b4d97f link /test istio-pilot-e2e-v1alpha3
prow/istio-pilot-e2e.sh 6b4d97f link /test istio-pilot-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ldemailly

Copy link
Copy Markdown
Member

can you make sure your PR is current with master ?
it also conflicts/overlaps with #4231

and some the vendor changes are already in vendor master

@istio-merge-robot

Copy link
Copy Markdown

@kyessenov PR needs rebase

@istio-merge-robot istio-merge-robot added the needs-rebase Indicates a PR needs to be rebased before being merged label Mar 30, 2018
Comment thread Gopkg.lock
"pkg/util"
]
revision = "aa344ee5f4fff239fadab634413ca6764025511c"
revision = "9fdf4bd79736a87c78b3d48b7baa84ea24be1c1a"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to much trouble to ask for adding /envoy/config/filter/http/jwt_authn/v2alpha in this PR as well. It would save me some time :)

@kyessenov

Copy link
Copy Markdown
Contributor Author

Superseded by @ldemailly 's PR.

@kyessenov kyessenov closed this Mar 30, 2018
@kyessenov kyessenov deleted the update-03-28 branch March 30, 2018 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR needs to be rebased before being merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants