Remove the galley deployment#22632
Merged
istio-testing merged 5 commits intoistio:masterfrom Apr 3, 2020
Merged
Conversation
istio-testing
added
the
do-not-merge/work-in-progress
googlebot
added
the
cla: yes
istio-testing
added
size/S
ayj
reviewed
Apr 1, 2020
Contributor
There was a problem hiding this comment.
This should be ported over to istiod since we support status updates there now. @therealmitchconnors, this should mostly be copy/paste except for enabling the analysis feature, right?
Member
Author
There was a problem hiding this comment.
Mitch already added this to istiod with tests in #22364 - or at least I think this is the same feature?
istio-testing
removed
the
do-not-merge/work-in-progress
hzxuzhonghu
approved these changes
Apr 3, 2020
howardjohn
force-pushed
the
exp/galley-disable
branch
from
9ba303c to
b9a24e3
Compare
Contributor
|
/retest |
ericvn
approved these changes
Apr 3, 2020
ericvn
approved these changes
Apr 3, 2020
Contributor
ericvn
left a comment
ericvn
left a comment
There was a problem hiding this comment.
Thanks for adding the test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the networking WG we agreed to remove the galley deployment for 1.6. The validation and status controllers have migrated to Istiod. The remaining feature gap is an MCP source, which we have decided to drop support for. (NOTE: istiod still can act as an MCP sync).