Skip to content

Add integration with Envoy's MySQL Proxy filter#11279

Merged
rshriram merged 3 commits intoistio:release-1.1from
venilnoronha:add-mysql-filter
Jan 25, 2019
Merged

Add integration with Envoy's MySQL Proxy filter#11279
rshriram merged 3 commits intoistio:release-1.1from
venilnoronha:add-mysql-filter

Conversation

@venilnoronha
Copy link
Member

This adds support for redirecting traffic through Envoy's MySQL Proxy
filter.

This adds support for redirecting traffic through Envoy's MySQL Proxy
filter.

Signed-off-by: Venil Noronha <veniln@vmware.com>
@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: venilnoronha
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid

If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyessenov
Copy link
Contributor

@rshriram is it possible to insert mixer filter into or prior to mysql filter?

This adds a guard that ensures that the correct proxy version is
available (in this case v1.1) prior to configuring Redis and MySQL
Envoy filters to ensure backward compatibility.

Signed-off-by: Venil Noronha <veniln@vmware.com>
Signed-off-by: Venil Noronha <veniln@vmware.com>
@istio-testing
Copy link
Collaborator

@venilnoronha: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-integ-k8s-tests.sh dbfd0d1 link /test istio-integ-k8s-tests
prow/istio-pilot-multicluster-e2e.sh dbfd0d1 link /test istio-pilot-multicluster-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram
Copy link
Member

mysql filter is just like mongo.. readonly and stacked on top of mixer+tcp proxy

@rshriram rshriram merged commit 6f7a319 into istio:release-1.1 Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants