Skip to content

Fix sidecars not retrieving updated mesh networks configuration#11222

Merged
rshriram merged 4 commits intoistio:release-1.1from
ymesika:meshNetworksUpdatesFix
Jan 25, 2019
Merged

Fix sidecars not retrieving updated mesh networks configuration#11222
rshriram merged 4 commits intoistio:release-1.1from
ymesika:meshNetworksUpdatesFix

Conversation

@ymesika
Copy link
Member

@ymesika ymesika commented Jan 24, 2019

Fixes #11221

/assign @hzxuzhonghu

Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not complete, should also consider kube Controller.ranger update

@hzxuzhonghu
Copy link
Member

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, ymesika

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Collaborator

@ymesika: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-multicluster-e2e.sh 0ce77ca link /test istio-pilot-multicluster-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram rshriram merged commit ac95ff3 into istio:release-1.1 Jan 25, 2019
@ymesika ymesika deleted the meshNetworksUpdatesFix branch January 27, 2019 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants