Skip to content

update value for one namespace.#11148

Merged
linsun merged 2 commits intoistio:release-1.1from
morvencao:br_onenamespace
Jan 23, 2019
Merged

update value for one namespace.#11148
linsun merged 2 commits intoistio:release-1.1from
morvencao:br_onenamespace

Conversation

@morvencao
Copy link
Copy Markdown
Member

@morvencao morvencao commented Jan 22, 2019

Since we have deprecated the istiotesting.oneNameSpace, we need to update value for oneNamespace installation.

@morvencao morvencao requested a review from linsun January 22, 2019 14:49
@morvencao morvencao requested review from sdake and removed request for costinm and nmittler January 22, 2019 14:50
@morvencao
Copy link
Copy Markdown
Member Author

morvencao commented Jan 22, 2019

/test istio-unit-tests

@ymesika
Copy link
Copy Markdown
Member

ymesika commented Jan 22, 2019

/lgtm

linsun
linsun reviewed Jan 22, 2019
View reviewed changes
install/kubernetes/helm/istio/values-istio-one-namespace-auth.yaml
istiotesting:
oneNameSpace: true

oneNamespace: true
Copy link
Copy Markdown
Member

@linsun linsun Jan 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we leave some comment for this? before, it is a testing param, I can safely ignore it.

Copy link
Copy Markdown
Member Author

@morvencao morvencao Jan 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments for the oneNamespace parameter.

linsun
linsun reviewed Jan 22, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@linsun linsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

@morvencao
Copy link
Copy Markdown
Member Author

morvencao commented Jan 23, 2019

/test istio-pilot-multicluster-e2e

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jan 23, 2019

@morvencao: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-integ-k8s-tests.sh 6db5b2f link /test istio-integ-k8s-tests
prow/istio-pilot-multicluster-e2e.sh 6db5b2f link /test istio-pilot-multicluster-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

linsun
linsun approved these changes Jan 23, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@linsun linsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@linsun
Copy link
Copy Markdown
Member

linsun commented Jan 23, 2019

@wenchenglu @duderino can we get this minor change in?

@wenchenglu
Copy link
Copy Markdown
Contributor

wenchenglu commented Jan 23, 2019

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jan 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: linsun, morvencao, wenchenglu, ymesika

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linsun linsun merged commit f749512 into istio:release-1.1 Jan 23, 2019
@morvencao morvencao deleted the br_onenamespace branch January 24, 2019 00:55
hklai pushed a commit to hklai/istio that referenced this pull request Jan 27, 2019
@hklai
update value for one namespace. (istio#11148)
ae58b9a 
* update value for one namespace.

* add comments for oneNamespace parameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linsun linsun linsun approved these changes

@sdake sdake Awaiting requested review from sdake

Assignees

@wenchenglu wenchenglu

@ymesika ymesika

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@morvencao @ymesika @istio-testing @linsun @wenchenglu @googlebot