Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kiali] issue 19232 talk about changing configmap #5879

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

jmazzitelli
Copy link
Member

@jmazzitelli jmazzitelli commented Nov 26, 2019

@jmazzitelli jmazzitelli requested a review from a team as a code owner November 26, 2019 15:57
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 26, 2019
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 26, 2019
Copy link
Member

@jwendell jwendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about a new section like Changing Kiali Configuration?
There you could explain in more detail how to change kiali config, with copy&paste commands for editing the CM and restarting the pods.

In the future, when Kiali is managed by the operator, that section would be changed to instruct users to update the CR...

@ericvn
Copy link
Contributor

ericvn commented Dec 18, 2019

Did you mean to put these into 1.4 without putting them in master? Normally, things are put into master and cherrypicked back. Else this might need to be cherrypicked to master from 1.4?

@jmazzitelli
Copy link
Member Author

Did you mean to put these into 1.4 without putting them in master? Normally, things are put into master and cherrypicked back. Else this might need to be cherrypicked to master from 1.4?

The reason is because we hope in the next release users shouldn't even know about/care/edit the configmap - that's for the kiali operator (and only the kiali operator) to modify.

So while this is valid for 1.4, it hopefully should not be valid instructions going forward and thus not in master.

Hopefully, these PRs can get combined/merged once the installer/operator repos get combined into the "monorepo":

istio/installer#556
istio/operator#622

That will introduce the kiali operator and the instructions in this PR will no longer be valid.

@adammil2000
Copy link
Contributor

@jmazzitelli We should continue to hold the approval of this PR until these other two are completed, correct?

istio/installer#556
istio/operator#622

Thanks!

@jmazzitelli
Copy link
Member Author

@adammil2000 actually, this PR should be merged... this PR is going in the istio 1.4 documentation - and these doc changes are relevant for that istio version.

We do not want these doc changes in master because the hope is the kiali operator will make it into Istio 1.5's istioctl (that's what the changes in those two PRs will attempt to do) and thus makes the docs in this PR obsolete.

@istio-testing istio-testing merged commit c55b83a into istio:release-1.4 Jan 3, 2020
@jmazzitelli jmazzitelli deleted the kiali-update-config branch January 3, 2020 23:07
so-jelly pushed a commit to so-jelly/istio.io that referenced this pull request Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. kind/docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants