-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kiali] issue 19232 talk about changing configmap #5879
[kiali] issue 19232 talk about changing configmap #5879
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about a new section like Changing Kiali Configuration
?
There you could explain in more detail how to change kiali config, with copy&paste commands for editing the CM and restarting the pods.
In the future, when Kiali is managed by the operator, that section would be changed to instruct users to update the CR...
Did you mean to put these into 1.4 without putting them in master? Normally, things are put into master and cherrypicked back. Else this might need to be cherrypicked to master from 1.4? |
The reason is because we hope in the next release users shouldn't even know about/care/edit the configmap - that's for the kiali operator (and only the kiali operator) to modify. So while this is valid for 1.4, it hopefully should not be valid instructions going forward and thus not in master. Hopefully, these PRs can get combined/merged once the installer/operator repos get combined into the "monorepo": istio/installer#556 That will introduce the kiali operator and the instructions in this PR will no longer be valid. |
@jmazzitelli We should continue to hold the approval of this PR until these other two are completed, correct? istio/installer#556 Thanks! |
@adammil2000 actually, this PR should be merged... this PR is going in the istio 1.4 documentation - and these doc changes are relevant for that istio version. We do not want these doc changes in master because the hope is the kiali operator will make it into Istio 1.5's istioctl (that's what the changes in those two PRs will attempt to do) and thus makes the docs in this PR obsolete. |
fixes istio/istio#19232