The current global hub and tag defaults are only for dev#5131
Merged
istio-testing merged 1 commit intorelease-1.3from Oct 11, 2019
Merged
The current global hub and tag defaults are only for dev#5131istio-testing merged 1 commit intorelease-1.3from
istio-testing merged 1 commit intorelease-1.3from
Conversation
In release this is changed to below: ```yaml global: # Default hub for Istio images. # Releases are published to docker hub under 'istio' project. # Daily builds from prow are on gcr.io hub: docker.io/istio # Default tag for Istio images. tag: 1.3.2 ``` Not sure how to fix, but having the dev defaults here may be misleading.
googlebot
added
the
cla: yes
istio-testing
added
the
size/XS
sdake
approved these changes
Oct 11, 2019
elfinhe
added
the
cherrypick/master
Member
Author
|
/cherrypick master |
Contributor
|
@elfinhe: new pull request created: #5172 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
charili
pushed a commit
to charili/istio.io
that referenced
this pull request
Nov 10, 2019
In release this is changed to below: ```yaml global: # Default hub for Istio images. # Releases are published to docker hub under 'istio' project. # Daily builds from prow are on gcr.io hub: docker.io/istio # Default tag for Istio images. tag: 1.3.2 ``` Not sure how to fix, but having the dev defaults here may be misleading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In release this is changed to below:
Not sure how to fix, but having the dev defaults here may be misleading.
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure