1.3.3 release notes by brian-avery · Pull Request #5122 · istio/istio.io

brian-avery · 2019-10-10T20:35:32Z

Please provide a description for what this PR is for.

And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ x] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

content/en/news/2019/announcing-1.3.3/index.md

rlenglet · 2019-10-10T20:48:29Z

Can you also update the full_version number in data/args.yaml like in #5070? I think it's better to do it all in a single PR.

brian-avery · 2019-10-10T22:21:40Z

Sure. This is the PR to master though, which is already updated to 1.4. Will add that in the cherry pick branch.

rlenglet · 2019-10-10T22:30:34Z

Sure. This is the PR to master though, which is already updated to 1.4. Will add that in the cherry pick branch.

Sure, you're right.

Co-Authored-By: Romain Lenglet <romain.lenglet@berabera.info>

googlebot · 2019-10-10T23:41:43Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-10-10T23:46:04Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

content/en/news/2019/announcing-1.3.3/index.md

googlebot · 2019-10-11T00:14:17Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-10-11T00:16:08Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

brian-avery · 2019-10-11T16:57:26Z

/test lint_istio.io

brian-avery · 2019-10-11T18:15:16Z

Added do not merge label in this PR so we can merge it on release.

geeknoid · 2019-10-11T18:44:37Z

@brian-avery Note that this will need to be merged into release-1.3 in order to be published to istio.io. And note that as part o merging the PR to that branch, you also need to update the full_version field in data/args.yaml.

brian-avery · 2019-10-11T18:46:57Z

@geeknoid Understood. Thanks. Added the cherry-pick to 1.3 label already, so as soon as this merges, that PR will open. Master already has data/args updated for 1.4 so I'm going to update the cherry-pick branch with the change.

googlebot · 2019-10-11T19:12:51Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

brian-avery · 2019-10-11T19:24:31Z

@googlebot I fixed it

googlebot · 2019-10-11T20:04:00Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

kyessenov

nothing from policy&telemetry

rlenglet · 2019-10-14T17:33:12Z

The tests on 1.3.3 look good. We can go ahead with the release.

* 1.3.3 release notes * 1.3.3 release notes * Apply suggestions from code review Co-Authored-By: Romain Lenglet <romain.lenglet@berabera.info> * Added note regarding Envoy crash

* 1.3.3 release notes (#5122) * 1.3.3 release notes * 1.3.3 release notes * Apply suggestions from code review Co-Authored-By: Romain Lenglet <romain.lenglet@berabera.info> * Added note regarding Envoy crash * Update full_version to 1.3.3

* 1.3.3 release notes (istio#5122) * 1.3.3 release notes * 1.3.3 release notes * Apply suggestions from code review Co-Authored-By: Romain Lenglet <romain.lenglet@berabera.info> * Added note regarding Envoy crash * Update full_version to 1.3.3

brian-avery added 2 commits October 10, 2019 16:23

1.3.3 release notes

742bfce

1.3.3 release notes

c132a17

brian-avery requested a review from a team as a code owner October 10, 2019 20:35

googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 10, 2019

istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 10, 2019

brian-avery requested review from a team, rlenglet and sdake October 10, 2019 20:37

rlenglet mentioned this pull request Oct 10, 2019

Create 1.3.3 release istio/istio#17765

Closed

24 tasks

brian-avery added the cherrypick/release-1.3 label Oct 10, 2019

rlenglet suggested changes Oct 10, 2019

View reviewed changes

Apply suggestions from code review

6677bbf

Co-Authored-By: Romain Lenglet <romain.lenglet@berabera.info>

googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels Oct 10, 2019

rlenglet added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Oct 10, 2019

rlenglet reviewed Oct 10, 2019

View reviewed changes

content/en/news/2019/announcing-1.3.3/index.md Outdated Show resolved Hide resolved

Fixed PR comments

5c7cd39

googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels Oct 11, 2019

rlenglet approved these changes Oct 11, 2019

View reviewed changes

rlenglet removed the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Oct 11, 2019

rlenglet added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 11, 2019

brian-avery added the do-not-merge Block automatic merging of a PR. label Oct 11, 2019

Added note regarding Envoy crash

65d4cc7

googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels Oct 11, 2019

JimmyCYJ approved these changes Oct 11, 2019

View reviewed changes

rlenglet added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Oct 11, 2019

kyessenov reviewed Oct 11, 2019

View reviewed changes

mandarjog approved these changes Oct 12, 2019

View reviewed changes

geeknoid approved these changes Oct 14, 2019

View reviewed changes

geeknoid removed do-not-merge Block automatic merging of a PR. cherrypick/release-1.3 labels Oct 14, 2019

istio-testing merged commit 955b93a into istio:master Oct 14, 2019

rlenglet pushed a commit that referenced this pull request Oct 14, 2019

1.3.3 release notes (#5122)

a999925

* 1.3.3 release notes * 1.3.3 release notes * Apply suggestions from code review Co-Authored-By: Romain Lenglet <romain.lenglet@berabera.info> * Added note regarding Envoy crash

This was referenced Oct 14, 2019

1.3.3 release notes #5149

Closed

1.3.3 release notes #5150

Merged

rlenglet pushed a commit that referenced this pull request Oct 14, 2019

1.3.3 release notes (#5122)

2ad39d1

* 1.3.3 release notes * 1.3.3 release notes * Apply suggestions from code review Co-Authored-By: Romain Lenglet <romain.lenglet@berabera.info> * Added note regarding Envoy crash

Conversation

brian-avery commented Oct 10, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rlenglet commented Oct 10, 2019

Uh oh!

brian-avery commented Oct 10, 2019

Uh oh!

rlenglet commented Oct 10, 2019

Uh oh!

googlebot commented Oct 10, 2019

Uh oh!

googlebot commented Oct 10, 2019

Uh oh!

Uh oh!

googlebot commented Oct 11, 2019

Uh oh!

googlebot commented Oct 11, 2019

Uh oh!

brian-avery commented Oct 11, 2019

Uh oh!

brian-avery commented Oct 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geeknoid commented Oct 11, 2019

Uh oh!

brian-avery commented Oct 11, 2019

Uh oh!

googlebot commented Oct 11, 2019

Uh oh!

brian-avery commented Oct 11, 2019

Uh oh!

googlebot commented Oct 11, 2019

Uh oh!

kyessenov left a comment

Choose a reason for hiding this comment

Uh oh!

rlenglet commented Oct 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

brian-avery commented Oct 11, 2019 •

edited

Loading