Skip to content

[release-1.3] fix link issue#5116

Merged
frankbu merged 4 commits intoistio:release-1.3from
istio-testing:cherry-pick-5115-to-release-1.3
Oct 9, 2019
Merged

[release-1.3] fix link issue#5116
frankbu merged 4 commits intoistio:release-1.3from
istio-testing:cherry-pick-5115-to-release-1.3

Conversation

@istio-testing
Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #5115

@istio-testing istio-testing requested a review from a team as a code owner October 9, 2019 19:10
@istio-testing istio-testing mentioned this pull request Oct 9, 2019
@googlebot
Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Oct 9, 2019
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 9, 2019
@istio-testing
Copy link
Copy Markdown
Contributor Author

@istio-testing: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
lint_istio.io_release-1.3 30157dc link /test lint_istio.io_release-1.3
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu frankbu merged commit 76d7ba6 into istio:release-1.3 Oct 9, 2019
@geeknoid
Copy link
Copy Markdown
Contributor

geeknoid commented Oct 9, 2019

@linsun There remains a lint error in release-1.3. 1.3.x needs to be added to .spelling in the 1.3 branch.

@frankbu
Copy link
Copy Markdown
Collaborator

frankbu commented Oct 9, 2019

@geeknoid @linsun, the other lint error was fixed in a separate PR. I force merged this cherry-pick because I knew it's there.

@linsun
Copy link
Copy Markdown
Member

linsun commented Oct 9, 2019

Thanks @frankbu - yes I can also confirm that lint error was fixed in .3 branch earlier @geeknoid

charili pushed a commit to charili/istio.io that referenced this pull request Nov 10, 2019
* fix link issue

* space

* use the link frank suggested

* Update content/en/news/2019/istio-security-2019-005/index.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants