Skip to content

Ensure consistent use of 'multicluster'.#5108

Merged
geeknoid merged 2 commits intoistio:masterfrom
rcaballeromx:const-multi
Oct 9, 2019
Merged

Ensure consistent use of 'multicluster'.#5108
geeknoid merged 2 commits intoistio:masterfrom
rcaballeromx:const-multi

Conversation

@rcaballeromx
Copy link
Copy Markdown
Contributor

Also fixes lint errors for versions.

Signed-off-by: rcaballeromx grca@google.com

[ ] Configuration Infrastructure
[ X ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Also fixes lint errors for versions.

Signed-off-by: rcaballeromx <grca@google.com>
@rcaballeromx rcaballeromx requested a review from a team as a code owner October 8, 2019 20:18
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 8, 2019
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 8, 2019
@geeknoid
Copy link
Copy Markdown
Contributor

geeknoid commented Oct 8, 2019

Please undo the changes to the release announcement, Lin is taking care of those in #5106.

Thanks.

Signed-off-by: rcaballeromx <grca@google.com>
@rcaballeromx
Copy link
Copy Markdown
Contributor Author

@geeknoid Done, thanks.

@istio-testing
Copy link
Copy Markdown
Contributor

@rcaballeromx: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
lint_istio.io 48c7a77 link /test lint_istio.io
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid geeknoid merged commit 4492b89 into istio:master Oct 9, 2019
@rcaballeromx rcaballeromx deleted the const-multi branch October 9, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. kind/docs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants