Skip to content

release note and announcement for 1.3.2/1.1.16/1.2.7#5105

Merged
linsun merged 3 commits intorelease-1.3from
release-13-patch
Oct 8, 2019
Merged

release note and announcement for 1.3.2/1.1.16/1.2.7#5105
linsun merged 3 commits intorelease-1.3from
release-13-patch

Conversation

@linsun
Copy link
Copy Markdown
Member

@linsun linsun commented Oct 8, 2019

Please provide a description for what this PR is for.

And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[x ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@linsun linsun requested review from a team and geeknoid as code owners October 8, 2019 18:11
@istio-testing
Copy link
Copy Markdown
Contributor

@linsun: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing added needs-rebase Indicates a PR needs to be rebased before being merged size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 8, 2019
@linsun linsun changed the base branch from master to release-1.3 October 8, 2019 18:11
@googlebot
Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Oct 8, 2019
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 8, 2019
@istio-testing
Copy link
Copy Markdown
Contributor

@linsun: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
lint_istio.io 9555168 link /test lint_istio.io
lint_istio.io_release-1.3 9555168 link /test lint_istio.io_release-1.3
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Contributor

@liminw liminw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@linsun
Copy link
Copy Markdown
Member Author

linsun commented Oct 8, 2019

not sure why lint failed, will play with it in #5106

@linsun linsun merged commit 1528c87 into release-1.3 Oct 8, 2019
@linsun linsun deleted the release-13-patch branch October 8, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. needs-rebase Indicates a PR needs to be rebased before being merged size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants