Skip to content

Adding Tip not to enable global sds#5040

Merged
geeknoid merged 6 commits intoistio:release-1.3from
rjshrjndrn:patch-1
Oct 3, 2019
Merged

Adding Tip not to enable global sds#5040
geeknoid merged 6 commits intoistio:release-1.3from
rjshrjndrn:patch-1

Conversation

@rjshrjndrn
Copy link
Copy Markdown

@rjshrjndrn rjshrjndrn commented Sep 23, 2019

While deploying certmanager, if somebody enables sds in values.yml rather than passing it via cli, their pods never become healthy as it'll enable mtls.

[ ] Configuration Infrastructure
[ x ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

While deploying certmanager, if somebody enables sds in values.yml rather than passing it via cli, their pods never become healthy as it'll enable mtls.
@rjshrjndrn rjshrjndrn requested a review from a team as a code owner September 23, 2019 14:01
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Sep 23, 2019
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Sep 23, 2019
@istio-testing
Copy link
Copy Markdown
Contributor

Hi @rjshrjndrn. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rjshrjndrn
Copy link
Copy Markdown
Author

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Sep 23, 2019
@geeknoid
Copy link
Copy Markdown
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Sep 24, 2019
…gr/index.md

Co-Authored-By: Martin Taillefer <geeknoid@users.noreply.github.com>
@rjshrjndrn
Copy link
Copy Markdown
Author

@geeknoid Can you please help me to fix the error. I'm literally in oblivion.

 - ./public/docs/tasks/traffic-management/ingress/ingress-certmgr/index.html
  *  31983:134: ERROR: Unexpected end tag : p (line 31983) 

@geeknoid
Copy link
Copy Markdown
Contributor

You've hit a bug in Hugo that happens on rare occasions with specific compositions of text blocks.

Instead of , try <text_hack yaml>. That may well work around the problem.

@rjshrjndrn
Copy link
Copy Markdown
Author

@geeknoid No luck even with that.
I tried

{{<text_hack yaml>}}
----
{{</text>}}
{{<text_hack yaml>}}
----
{{</text_hack>}}

Both are failing.

@geeknoid
Copy link
Copy Markdown
Contributor

The error you're seeing now is very different than before. Now, all you have is a spelling error:

./en/docs/tasks/traffic-management/ingress/ingress-certmgr/index.md
35 | If you're editing the values.yml file, don't enable

Just put values.yml in backticks and that should get things working.

@rjshrjndrn
Copy link
Copy Markdown
Author

/retest

@geeknoid geeknoid requested a review from liminw September 26, 2019 18:58
@geeknoid geeknoid requested review from a team and removed request for liminw September 26, 2019 18:58
@geeknoid geeknoid added the cherrypick/master Set this label on a PR to auto-merge from a release branch to master label Sep 26, 2019
@geeknoid geeknoid merged commit b84e7aa into istio:release-1.3 Oct 3, 2019
@rjshrjndrn
Copy link
Copy Markdown
Author

@geeknoid Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherrypick/master Set this label on a PR to auto-merge from a release branch to master cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants