dark-mode-css-bug#5023
Merged
istio-testing merged 1 commit intoistio:masterfrom Sep 20, 2019
rvennam:dark-command-output
Merged
dark-mode-css-bug#5023istio-testing merged 1 commit intoistio:masterfrom rvennam:dark-command-output
istio-testing merged 1 commit intoistio:masterfrom
rvennam:dark-command-output
Conversation
googlebot
added
the
cla: yes
istio-testing
added
the
size/XS
Contributor
|
I've been meaning to track this down for a while. Instead of fixing the dark theme by changing the light theme, I think it would make sense to change that same property in the _dark-theme-syntax.css. WDYT? |
Contributor
Author
|
I don't believe this property is needed in light theme because of background color already matches. |
geeknoid
approved these changes
Sep 19, 2019
Contributor
|
/retest |
Contributor
|
In response to a cherrypick label: new pull request created: #5035 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some characters ( <, | ) appear highlighted in dark mode:
[ ] Configuration Infrastructure
[X] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure