Skip to content

Couple cherry picks#4990

Merged
geeknoid merged 2 commits intoistio:release-1.3from
geeknoid:release-1.3
Sep 13, 2019
Merged

Couple cherry picks#4990
geeknoid merged 2 commits intoistio:release-1.3from
geeknoid:release-1.3

Conversation

@geeknoid
Copy link
Contributor

No description provided.

Ram Vennam and others added 2 commits September 13, 2019 08:33
* tabs css #3992

* lint error

* lint error

* code review comments

(cherry picked from commit ccc9ca6)
(cherry picked from commit d71b114)
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Sep 13, 2019
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 13, 2019
@istio-testing
Copy link
Contributor

@geeknoid: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
lint_istio.io_release-1.3 c9084b5 link /test lint_istio.io_release-1.3
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid geeknoid merged commit a32b1e7 into istio:release-1.3 Sep 13, 2019
@geeknoid geeknoid deleted the release-1.3 branch September 13, 2019 15:39
geeknoid added a commit that referenced this pull request Sep 13, 2019
* Improve Tabs CSS (#4980)

(cherry picked from commit ccc9ca6)

* Fixes for the archive site. (#4989)

(cherry picked from commit d71b114)
charili pushed a commit to charili/istio.io that referenced this pull request Nov 10, 2019
* Improve Tabs CSS (istio#4980)

(cherry picked from commit ccc9ca6)

* Fixes for the archive site. (istio#4989)

(cherry picked from commit d71b114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants